You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/07 22:14:42 UTC
[GitHub] [airflow] potiuk opened a new pull request #15262: Builds and pushes images in parallel
potiuk opened a new pull request #15262:
URL: https://github.com/apache/airflow/pull/15262
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #15262: Builds and pushes images in parallel
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #15262:
URL: https://github.com/apache/airflow/pull/15262#issuecomment-825030947
Closing it. There are at most marginal improvements and multitude of problems when images are build in parallel. Docker build does not cope well with several builds runnning in parallel (apparently creating layers in docker are single threaded) also building three prod images on the same public Github runner uses far too much space.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #15262: Builds and pushes images in parallel
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #15262:
URL: https://github.com/apache/airflow/pull/15262#issuecomment-818020791
> Do you have a build run in your own fork where these changed files have been used?
Yeah. I am mostly running and adding some fixes in my own fork, once I get it green, I will push it here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #15262: Builds and pushes images in parallel
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #15262:
URL: https://github.com/apache/airflow/pull/15262#issuecomment-818020949
Converted to Draft for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #15262: Builds and pushes images in parallel
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #15262:
URL: https://github.com/apache/airflow/pull/15262#issuecomment-822683919
@ashb the fork build is here: https://github.com/potiuk/airflow/actions/runs/764521494 (build image). I think it should be green now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #15262: Builds and pushes images in parallel
Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #15262:
URL: https://github.com/apache/airflow/pull/15262
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #15262: Builds and pushes images in parallel
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #15262:
URL: https://github.com/apache/airflow/pull/15262#issuecomment-815298337
I think this one is last to go for the parallelism
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #15262: Builds and pushes images in parallel
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #15262:
URL: https://github.com/apache/airflow/pull/15262#issuecomment-817913693
Do you have a build run in your own fork where these changed files have been used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org