[GitHub] nigjo commented on a change in pull request #433: [NETBEANS-417] Adjust C file to handle new registry layout starting with jdk9

[GitBox <gi...@apache.org>]

nigjo commented on a change in pull request #433: [NETBEANS-417] Adjust C file to handle new registry layout starting with jdk9 
URL: https://github.com/apache/incubator-netbeans/pull/433#discussion_r170049662
 
 

 ##########
 File path: o.n.bootstrap/launcher/windows/jvmlauncher.cpp
 ##########
 @@ -405,6 +407,13 @@ bool JvmLauncher::findJava(const char *minJavaVersion) {
     if (findJava(JRE_KEY, "", minJavaVersion)) {
         return true;
     }
+// scan for registry for jdk/jre version 9
+    if (findJava(JDK_POST9_KEY, "", minJavaVersion)) {
+        return true;
+    }
+    if (findJava(JRE_POST9_KEY, "", minJavaVersion)) {
+        return true;
+    }
 
 Review comment:
   Wouldn't it be better to check the new layout first to start the new version in favor of the old one?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists