You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/09/19 14:48:50 UTC

[GitHub] [incubator-kyuubi] kezhenxu94 commented on a change in pull request #1117: [WIP] push docker image

kezhenxu94 commented on a change in pull request #1117:
URL: https://github.com/apache/incubator-kyuubi/pull/1117#discussion_r711756302



##########
File path: .github/workflows/image.yml
##########
@@ -0,0 +1,37 @@
+name: Publish Docker image
+
+on:
+  push:
+    branches:
+      - master
+  pull_request:

Review comment:
       Pushing docker images for every pull request is not a good practice, it’s better to push the images only when the commit is pushed to master branch. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org