You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by David Smiley <da...@gmail.com> on 2016/09/30 20:24:55 UTC
SolrJ 6.2 now depends on Google-Guava and Jackson WTF?!
I was updating a project of mine today from SolrJ 6.0.0 to 6.2.1 and ran
into a classpath incompatibility problem pertaining to Guava. I execute
"mvn dependency:tree" to see what's going on and I see a huge WTF -- SolrJ
depends on Guava! Since when?! 6.2.0 apparently and in this issue --
https://issues.apache.org/jira/browse/SOLR-9200 Oh wow it depends on
Jackson now too!
Sorry, this is not okay and I feel strongly about this. Very deliberate
care should be taken to our SolrJ dependencies since they are used in many
environments, and dependencies there add a burden on anyone using Solr.
**Adding SolrJ dependencies should be announced**; either in their own
issue with appropriate title or noted in the dev list (not a JIRA issue) so
as to be noticed. Can we agree to do this from now on?
Fortunately, it *appears* that the usage is pretty minimal? Greg Chanan /
Steve Rowe, it appears the Guava dependency is just a couple import
statements for annotations. Is that it? I manually excluded guava from my
SolrJ dependency in the pom.xml along with things like Woodstox which I
always exclude. I'm not sure yet about the scope of Jackson; we haven't
needed that to date as we've got Noggit.
~ David
--
Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker
LinkedIn: http://linkedin.com/in/davidwsmiley | Book:
http://www.solrenterprisesearchserver.com
Re: SolrJ 6.2 now depends on Google-Guava and Jackson WTF?!
Posted by David Smiley <da...@gmail.com>.
Furthermore, changes to SolrJ dependencies should be noted clearly in
CHANGES.txt (e.g. new SolrJ dependency XYZ for purpose ___, or updated
SolrJ dependency XYZ to 1.2.3). I see no reference to this in CHANGES.txt.
On Fri, Sep 30, 2016 at 4:24 PM David Smiley <da...@gmail.com>
wrote:
> I was updating a project of mine today from SolrJ 6.0.0 to 6.2.1 and ran
> into a classpath incompatibility problem pertaining to Guava. I execute
> "mvn dependency:tree" to see what's going on and I see a huge WTF -- SolrJ
> depends on Guava! Since when?! 6.2.0 apparently and in this issue --
> https://issues.apache.org/jira/browse/SOLR-9200 Oh wow it depends on
> Jackson now too!
>
> Sorry, this is not okay and I feel strongly about this. Very deliberate
> care should be taken to our SolrJ dependencies since they are used in many
> environments, and dependencies there add a burden on anyone using Solr.
> **Adding SolrJ dependencies should be announced**; either in their own
> issue with appropriate title or noted in the dev list (not a JIRA issue) so
> as to be noticed. Can we agree to do this from now on?
>
> Fortunately, it *appears* that the usage is pretty minimal? Greg Chanan /
> Steve Rowe, it appears the Guava dependency is just a couple import
> statements for annotations. Is that it? I manually excluded guava from my
> SolrJ dependency in the pom.xml along with things like Woodstox which I
> always exclude. I'm not sure yet about the scope of Jackson; we haven't
> needed that to date as we've got Noggit.
>
> ~ David
> --
> Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker
> LinkedIn: http://linkedin.com/in/davidwsmiley | Book:
> http://www.solrenterprisesearchserver.com
>
--
Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker
LinkedIn: http://linkedin.com/in/davidwsmiley | Book:
http://www.solrenterprisesearchserver.com
Re: SolrJ 6.2 now depends on Google-Guava and Jackson WTF?!
Posted by Yonik Seeley <ys...@gmail.com>.
On Mon, Oct 3, 2016 at 11:26 PM, Timothy Potter <th...@gmail.com> wrote:
> on that note, what's that woodstox stuff used for?
Very old reasons:
Originally, license issues: http://markmail.org/message/tnsfyvykendpzcwq
And then performance issues, made worse by the non-thread-safe
factories: https://issues.apache.org/jira/browse/SOLR-360
But I don't think we use XML by default anywhere anymore... hence
performance shouldn't be much of a concern?
-Yonik
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: SolrJ 6.2 now depends on Google-Guava and Jackson WTF?!
Posted by Timothy Potter <th...@gmail.com>.
on that note, what's that woodstox stuff used for? I've recently hit a
problem trying to use SolrJ with JMeter and had to remove the woodstox
stuff to get passed it.
On Mon, Oct 3, 2016 at 1:06 AM, Noble Paul <no...@gmail.com> wrote:
> I totally agree with you. We should discuss it publicly before adding
> dependencies to SolrJ. SolrJ is used in so many environments and it has the
> potential to screw up a lot of users.
>
>
>
> On Sat, Oct 1, 2016 at 1:54 AM, David Smiley <da...@gmail.com>
> wrote:
>>
>> I was updating a project of mine today from SolrJ 6.0.0 to 6.2.1 and ran
>> into a classpath incompatibility problem pertaining to Guava. I execute
>> "mvn dependency:tree" to see what's going on and I see a huge WTF -- SolrJ
>> depends on Guava! Since when?! 6.2.0 apparently and in this issue --
>> https://issues.apache.org/jira/browse/SOLR-9200 Oh wow it depends on
>> Jackson now too!
>>
>> Sorry, this is not okay and I feel strongly about this. Very deliberate
>> care should be taken to our SolrJ dependencies since they are used in many
>> environments, and dependencies there add a burden on anyone using Solr.
>> **Adding SolrJ dependencies should be announced**; either in their own issue
>> with appropriate title or noted in the dev list (not a JIRA issue) so as to
>> be noticed. Can we agree to do this from now on?
>>
>> Fortunately, it *appears* that the usage is pretty minimal? Greg Chanan /
>> Steve Rowe, it appears the Guava dependency is just a couple import
>> statements for annotations. Is that it? I manually excluded guava from my
>> SolrJ dependency in the pom.xml along with things like Woodstox which I
>> always exclude. I'm not sure yet about the scope of Jackson; we haven't
>> needed that to date as we've got Noggit.
>>
>> ~ David
>> --
>> Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker
>> LinkedIn: http://linkedin.com/in/davidwsmiley | Book:
>> http://www.solrenterprisesearchserver.com
>
>
>
>
> --
> -----------------------------------------------------
> Noble Paul
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: SolrJ 6.2 now depends on Google-Guava and Jackson WTF?!
Posted by Noble Paul <no...@gmail.com>.
I totally agree with you. We should discuss it publicly before adding
dependencies to SolrJ. SolrJ is used in so many environments and it has the
potential to screw up a lot of users.
On Sat, Oct 1, 2016 at 1:54 AM, David Smiley <da...@gmail.com>
wrote:
> I was updating a project of mine today from SolrJ 6.0.0 to 6.2.1 and ran
> into a classpath incompatibility problem pertaining to Guava. I execute
> "mvn dependency:tree" to see what's going on and I see a huge WTF -- SolrJ
> depends on Guava! Since when?! 6.2.0 apparently and in this issue --
> https://issues.apache.org/jira/browse/SOLR-9200 Oh wow it depends on
> Jackson now too!
>
> Sorry, this is not okay and I feel strongly about this. Very deliberate
> care should be taken to our SolrJ dependencies since they are used in many
> environments, and dependencies there add a burden on anyone using Solr.
> **Adding SolrJ dependencies should be announced**; either in their own
> issue with appropriate title or noted in the dev list (not a JIRA issue) so
> as to be noticed. Can we agree to do this from now on?
>
> Fortunately, it *appears* that the usage is pretty minimal? Greg Chanan /
> Steve Rowe, it appears the Guava dependency is just a couple import
> statements for annotations. Is that it? I manually excluded guava from my
> SolrJ dependency in the pom.xml along with things like Woodstox which I
> always exclude. I'm not sure yet about the scope of Jackson; we haven't
> needed that to date as we've got Noggit.
>
> ~ David
> --
> Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker
> LinkedIn: http://linkedin.com/in/davidwsmiley | Book: http://www.
> solrenterprisesearchserver.com
>
--
-----------------------------------------------------
Noble Paul
Re: SolrJ 6.2 now depends on Google-Guava and Jackson WTF?!
Posted by Chris Hostetter <ho...@fucit.org>.
: Sorry, this is not okay and I feel strongly about this. Very deliberate
: care should be taken to our SolrJ dependencies since they are used in many
: environments, and dependencies there add a burden on anyone using Solr.
+1
We should really be striving to make solrj completely devoid of
dependencies.
-Hoss
http://www.lucidworks.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org