You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/11/22 03:28:49 UTC
[GitHub] [spark] LuciferYang opened a new pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
LuciferYang opened a new pull request #34676:
URL: https://github.com/apache/spark/pull/34676
### What changes were proposed in this pull request?
After SPARK-37272 and SPARK-37282, we can manually add
```
-Dtest.exclude.tags=org.apache.spark.tags.ExtendedLevelDBTest,org.apache.spark.tags.ExtendedRocksDBTest
```
when run `mvn test` or `sbt test` to disable unsupported UTs on MacOs using Apple Silicon.
This pr add a new profile to re-write `test.exclude.tags` property and activate it automatically when build on MacOs using Apple Silicon to simplify execution commands.
### Why are the changes needed?
Simplify test commands on MacOs using Apple Silicon.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
- Pass the Jenkins or GitHub Action
- Run the tests on M1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #34676: [WIP][SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-975041704
I'm testing this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-975342599
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145496/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-975342599
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145496/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-977529479
@LuciferYang Thank you @LuciferYang .
It's better to note the command lines in `How was this patch tested?` in the description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang edited a comment on pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
LuciferYang edited a comment on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-979649905
@sarutak @HyukjinKwon @sarutak thanks all, I will close this pr because it seems that the current test way using Apple Silicon is not the final way, thanks all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34676: [WIP][SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-975150371
**[Test build #145496 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145496/testReport)** for PR 34676 at commit [`f87a633`](https://github.com/apache/spark/commit/f87a633e17ac96d46ca432155faf710df4b63460).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak edited a comment on pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
sarutak edited a comment on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-977529479
Thank you @LuciferYang .
It's better to note the command lines in `How was this patch tested?` in the description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-975312553
**[Test build #145496 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145496/testReport)** for PR 34676 at commit [`f87a633`](https://github.com/apache/spark/commit/f87a633e17ac96d46ca432155faf710df4b63460).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang edited a comment on pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
LuciferYang edited a comment on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-976148375
@srowen you are right, f87467b adds code corresponding to sbt.
There are 3 modules with `Extended{LevelDB,RocksDB}Test` annotation: `core`,`sql/core`, `yarn`
for maven, we can use follow commands to test the effectiveness of the current pr:
```
mvn clean install -DskipTest -pl ${moduleName} ${-Pyarn}
mvn test -pl ${moduleName} ${-Pyarn}
```
For maven, we can use follow commands to test the effectiveness of the current pr:
```
mvn clean install -DskipTest -pl ${moduleName} [-Pyarn]
mvn test -pl ${moduleName} [-Pyarn]
```
For sbt, we can use follow commands to test the effectiveness of the current pr:
```
build/sbt "${moduleName}/test" [-Pyarn]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-976148375
@srowen you are right, f87467b adds code corresponding to sbt.
There are 3 modules with `Extended{LevelDB,RocksDB}Test` annotation: `core`,`sql/core`, `yarn`
for maven, we can use follow commands to test the effectiveness of the current pr:
```
mvn clean install -DskipTest -pl ${moduleName} ${-Pyarn}
mvn test -pl ${moduleName} ${-Pyarn}
```
For maven, we can use follow commands to test the effectiveness of the current pr:
```
mvn clean install -DskipTest -pl ${moduleName} ${-Pyarn}
mvn test -pl ${moduleName} ${-Pyarn}
```
For sbt, we can use follow commands to test the effectiveness of the current pr:
```
build/sbt "${moduleName}/test" -Pyarn
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #34676: [WIP][SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #34676:
URL: https://github.com/apache/spark/pull/34676#discussion_r753967179
##########
File path: pom.xml
##########
@@ -3580,6 +3580,18 @@
</os>
</activation>
</profile>
+ <profile>
+ <id>mac-on-apple-silicon</id>
+ <properties>
+ <test.exclude.tags>org.apache.spark.tags.ExtendedLevelDBTest,org.apache.spark.tags.ExtendedRocksDBTest</test.exclude.tags>
Review comment:
WDYT @dongjoon-hyun ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34676: [WIP][SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-975149858
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49966/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-975586524
@LuciferYang
BTW, how about SBT? I think this change doesn't care SBT.
Also, it's better to note how you tested more concretely (e.g. show the command lines) to allow reviewers to verify.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #34676:
URL: https://github.com/apache/spark/pull/34676#discussion_r754325315
##########
File path: pom.xml
##########
@@ -3580,6 +3580,18 @@
</os>
</activation>
</profile>
+ <profile>
+ <id>mac-on-apple-silicon</id>
+ <properties>
+ <test.exclude.tags>org.apache.spark.tags.ExtendedLevelDBTest,org.apache.spark.tags.ExtendedRocksDBTest</test.exclude.tags>
Review comment:
> So is it necessary for us to remind developers using M1 that they should manually add these tags when testing?
If users want to set `-Dtest.default.exclude.tags` manually (e.g. for removing `ChromeUITest` tag), they still need to know about `Extended{LevelDB,RocksDB}Test` tags because the default value of `test.default.exclude.tags` set by the `mac-on-apple-silicon` profile is overridden.
So, another option would be to note how to test using Apple silicon on [the developer's doc](http://spark.apache.org/developer-tools.html).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-978778064
**[Test build #145609 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145609/testReport)** for PR 34676 at commit [`b510f3a`](https://github.com/apache/spark/commit/b510f3ac0bca35d12527672ec5775bd95ca8ba67).
* This patch **fails Scala style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a change in pull request #34676: [WIP][SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on a change in pull request #34676:
URL: https://github.com/apache/spark/pull/34676#discussion_r753959557
##########
File path: pom.xml
##########
@@ -3580,6 +3580,18 @@
</os>
</activation>
</profile>
+ <profile>
+ <id>mac-on-apple-silicon</id>
+ <properties>
+ <test.exclude.tags>org.apache.spark.tags.ExtendedLevelDBTest,org.apache.spark.tags.ExtendedRocksDBTest</test.exclude.tags>
Review comment:
@HyukjinKwon 7a17868 change to re-write `test.default.exclude.tags`, in this way, we can still use `test.exclude.tags` in other scenarios. Can this ease your concerns?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-975208219
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49968/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang closed pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
LuciferYang closed pull request #34676:
URL: https://github.com/apache/spark/pull/34676
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-978777646
**[Test build #145609 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145609/testReport)** for PR 34676 at commit [`b510f3a`](https://github.com/apache/spark/commit/b510f3ac0bca35d12527672ec5775bd95ca8ba67).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-978778078
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145609/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-981609160
It sounds like a very interesting thing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34676: [WIP][SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-975049090
**[Test build #145494 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145494/testReport)** for PR 34676 at commit [`b8e917f`](https://github.com/apache/spark/commit/b8e917fe4d73cf6c8a78fb90764e2a1ebdb250a3).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34676: [WIP][SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-975180497
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145494/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34676: [WIP][SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-975178405
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49968/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-976149315
**[Test build #145531 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145531/testReport)** for PR 34676 at commit [`f87467b`](https://github.com/apache/spark/commit/f87467b48d7989fdd026d0b337de617b3f4f9e6d).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-979649905
@sarutak @HyukjinKwon @sarutak thanks all, I will close this pr because it seems that the current test way using Apple Silicon is not the final way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-979654595
@dongjoon-hyun Do we have any ideas about the fix of leveldb related issue now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #34676:
URL: https://github.com/apache/spark/pull/34676#discussion_r756506080
##########
File path: project/SparkBuild.scala
##########
@@ -1104,7 +1104,15 @@ object CopyDependencies {
object TestSettings {
import BuildCommons._
- private val defaultExcludedTags = Seq("org.apache.spark.tags.ChromeUITest")
+ private val isMacOnAppleSilicon = System.getProperty("os.name").startsWith("Mac OS X") &&
+ System.getProperty("os.arch").equals("aarch64")
+ private val defaultExcludedTags = if (isMacOnAppleSilicon) {
+ Seq("org.apache.spark.tags.ChromeUITest",
+ "org.apache.spark.tags.ExtendedLevelDBTest",
+ "org.apache.spark.tags.ExtendedRocksDBTest")
+ } else {
+ Seq("org.apache.spark.tags.ChromeUITest")
+ }
Review comment:
How about:
```suggestion
private val defaultExcludedTags = Seq("org.apache.spark.tags.ChromeUITest") ++
if (isMacOnAppleSilicon) {
Seq("org.apache.spark.tags.ExtendedLevelDBTest", "org.apache.spark.tags.ExtendedRocksDBTest")
} else {
Seq.empty
}
```
rather than duplicate `ChromeUITest`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #34676: [WIP][SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #34676:
URL: https://github.com/apache/spark/pull/34676#discussion_r753929523
##########
File path: pom.xml
##########
@@ -3580,6 +3580,18 @@
</os>
</activation>
</profile>
+ <profile>
+ <id>mac-on-apple-silicon</id>
+ <properties>
+ <test.exclude.tags>org.apache.spark.tags.ExtendedLevelDBTest,org.apache.spark.tags.ExtendedRocksDBTest</test.exclude.tags>
Review comment:
Hm, I think we don't need to bother with this for now. Testing tags are enough. I would prefer to avoid having profiles here for other combinations of tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34676: [WIP][SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-975049090
**[Test build #145494 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145494/testReport)** for PR 34676 at commit [`b8e917f`](https://github.com/apache/spark/commit/b8e917fe4d73cf6c8a78fb90764e2a1ebdb250a3).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang edited a comment on pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
LuciferYang edited a comment on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-976148375
@sarutak you are right, f87467b adds code corresponding to sbt.
There are 3 modules with `Extended{LevelDB,RocksDB}Test` annotation: `core`,`sql/core`, `yarn`
for maven, we can use follow commands to test the effectiveness of the current pr:
```
mvn clean install -DskipTest -pl ${moduleName} ${-Pyarn}
mvn test -pl ${moduleName} ${-Pyarn}
```
For maven, we can use follow commands to test the effectiveness of the current pr:
```
mvn clean install -DskipTest -pl ${moduleName} [-Pyarn]
mvn test -pl ${moduleName} [-Pyarn]
```
For sbt, we can use follow commands to test the effectiveness of the current pr:
```
build/sbt "${moduleName}/test" [-Pyarn]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-976185598
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50003/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-976207428
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145531/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-978895274
**[Test build #145615 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145615/testReport)** for PR 34676 at commit [`3386000`](https://github.com/apache/spark/commit/3386000816c75f75b31a36177bf6bc2a73bfc393).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-978905172
I respect your choice @sarutak @HyukjinKwon @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-978866335
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50087/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-978896363
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145615/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-978870967
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50083/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak edited a comment on pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
sarutak edited a comment on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-978899026
The change itself looks fine but we need to discuss this change is really necessary as @HyukjinKwon concerns.
https://github.com/apache/spark/pull/34676#discussion_r753929523
@dongjoon-hyun Do you have any opinions? I guess you sometimes run tests with Apple Silicon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34676: [WIP][SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-975146317
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49966/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-976177156
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50003/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34676: [WIP][SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-975102524
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49966/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-975214010
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49968/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-976207428
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145531/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a change in pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on a change in pull request #34676:
URL: https://github.com/apache/spark/pull/34676#discussion_r754788216
##########
File path: pom.xml
##########
@@ -3580,6 +3580,18 @@
</os>
</activation>
</profile>
+ <profile>
+ <id>mac-on-apple-silicon</id>
+ <properties>
+ <test.exclude.tags>org.apache.spark.tags.ExtendedLevelDBTest,org.apache.spark.tags.ExtendedRocksDBTest</test.exclude.tags>
Review comment:
If the user really needs to customize `-Dtest.default.exclude.tags` instead of `-Dtest.exclude.tags`, it is better to modify the developer's doc
##########
File path: pom.xml
##########
@@ -3580,6 +3580,18 @@
</os>
</activation>
</profile>
+ <profile>
+ <id>mac-on-apple-silicon</id>
+ <properties>
+ <test.exclude.tags>org.apache.spark.tags.ExtendedLevelDBTest,org.apache.spark.tags.ExtendedRocksDBTest</test.exclude.tags>
Review comment:
If user really needs to customize `-Dtest.default.exclude.tags` instead of `-Dtest.exclude.tags`, it is better to modify the developer's doc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-976165361
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50003/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-976185598
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50003/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-978896363
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145615/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-978870946
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50083/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-978892679
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50087/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-975039577
cc @dongjoon-hyun @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a change in pull request #34676: [WIP][SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on a change in pull request #34676:
URL: https://github.com/apache/spark/pull/34676#discussion_r753950582
##########
File path: pom.xml
##########
@@ -3580,6 +3580,18 @@
</os>
</activation>
</profile>
+ <profile>
+ <id>mac-on-apple-silicon</id>
+ <properties>
+ <test.exclude.tags>org.apache.spark.tags.ExtendedLevelDBTest,org.apache.spark.tags.ExtendedRocksDBTest</test.exclude.tags>
Review comment:
Ok ~ So is it necessary for us to remind developers using M1 that they should manually add these tags when testing? I don't think all developers know these at present.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34676: [WIP][SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-975149858
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49966/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-978808535
**[Test build #145615 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145615/testReport)** for PR 34676 at commit [`3386000`](https://github.com/apache/spark/commit/3386000816c75f75b31a36177bf6bc2a73bfc393).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-975214010
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49968/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-975150371
**[Test build #145496 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145496/testReport)** for PR 34676 at commit [`f87a633`](https://github.com/apache/spark/commit/f87a633e17ac96d46ca432155faf710df4b63460).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-978808535
**[Test build #145615 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145615/testReport)** for PR 34676 at commit [`3386000`](https://github.com/apache/spark/commit/3386000816c75f75b31a36177bf6bc2a73bfc393).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-978892647
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50087/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-978870967
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-981316245
Thank you for closing this PR, @LuciferYang .
Ya, `leveldb` JNI library is severely outdated while `RocksDB` shows its progress, https://github.com/facebook/rocksdb/issues/7720. Given that, I'm thinking about that we can make Spark `leveldb`-free. Specifically, we may replace `levelDB` part with `RocksDB` part because Spark SQL module already uses `RocksDB` too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a change in pull request #34676: [WIP][SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on a change in pull request #34676:
URL: https://github.com/apache/spark/pull/34676#discussion_r753959557
##########
File path: pom.xml
##########
@@ -3580,6 +3580,18 @@
</os>
</activation>
</profile>
+ <profile>
+ <id>mac-on-apple-silicon</id>
+ <properties>
+ <test.exclude.tags>org.apache.spark.tags.ExtendedLevelDBTest,org.apache.spark.tags.ExtendedRocksDBTest</test.exclude.tags>
Review comment:
@HyukjinKwon 7a17868 and f87a633 change to re-write `test.default.exclude.tags`, in this way, we can still use `test.exclude.tags` in other scenarios. Can this ease your concerns?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34676: [WIP][SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-975178783
**[Test build #145494 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145494/testReport)** for PR 34676 at commit [`b8e917f`](https://github.com/apache/spark/commit/b8e917fe4d73cf6c8a78fb90764e2a1ebdb250a3).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34676: [WIP][SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-975180497
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145494/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-978841145
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50083/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-976149315
**[Test build #145531 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145531/testReport)** for PR 34676 at commit [`f87467b`](https://github.com/apache/spark/commit/f87467b48d7989fdd026d0b337de617b3f4f9e6d).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-978902684
I am okay .. but let me defer to @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-976198419
**[Test build #145531 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145531/testReport)** for PR 34676 at commit [`f87467b`](https://github.com/apache/spark/commit/f87467b48d7989fdd026d0b337de617b3f4f9e6d).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-978777646
**[Test build #145609 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145609/testReport)** for PR 34676 at commit [`b510f3a`](https://github.com/apache/spark/commit/b510f3ac0bca35d12527672ec5775bd95ca8ba67).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-978899026
The change itself looks fine but we need to discuss this change is really necessary as @HyukjinKwon concerns.
@dongjoon-hyun Do you have any opinions? I guess you sometimes run tests with Apple Silicon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-978778078
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145609/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-979580809
Sorry, but I'm -1 for this auto-disablement because this hides all the issues from the most of the developers and doesn't help the developers fix the root causes. That's the reason why I didn't do that initially, @LuciferYang .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #34676:
URL: https://github.com/apache/spark/pull/34676#issuecomment-979649360
@dongjoon-hyun OK, if we have a plan to fix the issues related to leveldb and rocksdb on Apple Silicon, and the current test way is only a compromise, I think the current pr is really redundant. Thank you for your review ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org