You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/02 17:40:34 UTC
[GitHub] [spark] gaborgsomogyi commented on a change in pull request #24305:
[SPARK-27294][SS] Add multi-cluster Kafka delegation token
gaborgsomogyi commented on a change in pull request #24305: [SPARK-27294][SS] Add multi-cluster Kafka delegation token
URL: https://github.com/apache/spark/pull/24305#discussion_r280525659
##########
File path: external/kafka-0-10-token-provider/src/main/scala/org/apache/spark/kafka010/KafkaTokenUtil.scala
##########
@@ -38,20 +40,27 @@ import org.apache.spark.SparkConf
import org.apache.spark.deploy.SparkHadoopUtil
import org.apache.spark.internal.Logging
import org.apache.spark.internal.config._
+import org.apache.spark.util.Utils
private[spark] object KafkaTokenUtil extends Logging {
val TOKEN_KIND = new Text("KAFKA_DELEGATION_TOKEN")
- val TOKEN_SERVICE = new Text("kafka.server.delegation.token")
+ private val TOKEN_SERVICE_PREFIX = "kafka.server.delegation.token"
+
+ private[kafka010] def getTokenService(identifier: String): Text =
+ new Text(s"$TOKEN_SERVICE_PREFIX.$identifier")
+ private def getClusterIdentifier(service: Text): String =
Review comment:
Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org