You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/03/23 07:08:43 UTC
[GitHub] [dubbo-go] qq5272689 opened a new pull request #1099: 增加配置初始化的选项功能
qq5272689 opened a new pull request #1099:
URL: https://github.com/apache/dubbo-go/pull/1099
解决问题：
1、默认使用init初始化，灵活性欠佳，集成进例如cobra这样的框架不够方便，参数存在冲突。
2、原初始化后如果baseconf没有生成，没有相应的set方法重新设置
3、增加baseconf配置文件，优先使用配置文件加载，如不使用配置文件则按原先得方式加载
//保留原初始化方式，把原来的init()中的处理逻辑集成进Load()函数，使用方式不变。
config.Load()
//config_loader 增加option 功能，实现按需初始化。
`
//保留原初始化方式，把原来的init()中的处理逻辑集成进Load()函数，使用方式不变。
config.Load()
//新的初始化方式（按需初始化）
config.LoadWithOptions(config.BaseInitOption(""),config.ConsumerInitOption(confConFile))
//目前转化成6个初始化选项：
//RouterInitOption、ConsumerInitOption、ProviderInitOption、BaseInitOption、ConsumerMustInitOption、ProviderMustInitOption
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks merged pull request #1099: Imp: load the configure file in another way
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #1099:
URL: https://github.com/apache/dubbo-go/pull/1099
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #1099: 增加配置初始化的选项功能
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #1099:
URL: https://github.com/apache/dubbo-go/pull/1099#discussion_r604597235
##########
File path: config/base_config.go
##########
@@ -19,6 +19,7 @@ package config
import (
"bytes"
+ "github.com/apache/dubbo-go/common/yaml"
Review comment:
hey, guy, move it to the 3rd import block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] qq5272689 commented on a change in pull request #1099: 增加配置初始化的选项功能
Posted by GitBox <gi...@apache.org>.
qq5272689 commented on a change in pull request #1099:
URL: https://github.com/apache/dubbo-go/pull/1099#discussion_r605416503
##########
File path: config/base_config.go
##########
@@ -19,6 +19,7 @@ package config
import (
"bytes"
+ "github.com/apache/dubbo-go/common/yaml"
Review comment:
it's done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on pull request #1099: 增加配置初始化的选项功能
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on pull request #1099:
URL: https://github.com/apache/dubbo-go/pull/1099#issuecomment-810767863
cc @georgehao, pls review this pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on pull request #1099: 增加配置初始化的选项功能
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on pull request #1099:
URL: https://github.com/apache/dubbo-go/pull/1099#issuecomment-812857565
pls merge the latest code from branch 3.0 and fix the conflict. thx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org