[PR] fix: use Input & TextArea instead of native and [superset]</h1><pre> mistercrunch opened a new pull request, #32989: URL: https://github.com/apache/superset/pull/32989 Moving to using AntD so that the components are themed properly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org For queries about this service, please contact Infrastructure at: users@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org For additional commands, e-mail: notifications-help@superset.apache.org </pre><hr/> <h2>Re: [PR] fix: use Input & TextArea instead of native <input> and <textarea> [superset]</h2> <b>Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.</b><hr/><pre> mistercrunch merged PR #32989: URL: https://github.com/apache/superset/pull/32989 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org For queries about this service, please contact Infrastructure at: users@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org For additional commands, e-mail: notifications-help@superset.apache.org </pre><hr/> <h2>Re: [PR] fix: use Input & TextArea instead of native <input> and <textarea> [superset]</h2> <b>Posted by "geido (via GitHub)" <gi...@apache.org>.</b><hr/><pre> geido commented on code in PR #32989: URL: https://github.com/apache/superset/pull/32989#discussion_r2033782559 ########## superset-frontend/src/SqlLab/components/ResultSet/index.tsx: ########## @@ -406,8 +407,7 @@ const ResultSet = ({ )} </ResultSetButtons> {search && ( - <input - type="text" + <Input onChange={changeSearch} value={searchText} className="form-control input-sm" Review Comment: Wondering if we still need these class names. This might come from bootstrap -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org For queries about this service, please contact Infrastructure at: users@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org For additional commands, e-mail: notifications-help@superset.apache.org </pre><hr/> <h2>Re: [PR] fix: use Input & TextArea instead of native <input> and <textarea> [superset]</h2> <b>Posted by "geido (via GitHub)" <gi...@apache.org>.</b><hr/><pre> geido commented on code in PR #32989: URL: https://github.com/apache/superset/pull/32989#discussion_r2033760354 ########## superset-frontend/src/explore/components/DatasourcePanel/index.tsx: ########## @@ -276,18 +277,20 @@ export default function DataSourcePanel({ datasource.type && saveableDatasets[datasource.type as keyof typeof saveableDatasets]; + const theme = useTheme(); const mainBody = useMemo( () => ( <> - <Input - allowClear - onChange={evt => { - setInputValue(evt.target.value); - }} - value={inputValue} - className="form-control input-md" - placeholder={t('Search Metrics & Columns')} - /> + <div style={{ padding: theme.sizeUnit * 4 }}> Review Comment: Should we use a `Space` or `Flex` component for this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org For queries about this service, please contact Infrastructure at: users@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org For additional commands, e-mail: notifications-help@superset.apache.org </pre><hr/> <h2>Re: [PR] fix: use Input & TextArea instead of native <input> and <textarea> [superset]</h2> <b>Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.</b><hr/><pre> mistercrunch commented on code in PR #32989: URL: https://github.com/apache/superset/pull/32989#discussion_r2027549684 ########## superset-frontend/src/features/annotations/AnnotationModal.tsx: ########## @@ -70,7 +71,7 @@ const AnnotationContainer = styled.div` } textarea, - input[type='text'] { + Input { Review Comment: ooops, used "Aider" here and it went rogue... styles not required anymore... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org For queries about this service, please contact Infrastructure at: users@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org For additional commands, e-mail: notifications-help@superset.apache.org </pre><hr/> <h2>Re: [PR] fix: use Input & TextArea instead of native <input> and <textarea> [superset]</h2> <b>Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.</b><hr/><pre> mistercrunch commented on code in PR #32989: URL: https://github.com/apache/superset/pull/32989#discussion_r2033821932 ########## superset-frontend/src/components/Chart/DrillDetail/DrillDetailMenuItems.test.tsx: ########## @@ -396,7 +396,7 @@ test('context menu for supported chart, dimensions, filter B', async () => { await expectDrillToDetailByDimension(filterB); }); -test('context menu for supported chart, dimensions, all filters', async () => { +test.skip('context menu for supported chart, dimensions, all filters', async () => { Review Comment: oh good catch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org For queries about this service, please contact Infrastructure at: users@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org For additional commands, e-mail: notifications-help@superset.apache.org </pre><hr/> <h2>Re: [PR] fix: use Input & TextArea instead of native <input> and <textarea> [superset]</h2> <b>Posted by "geido (via GitHub)" <gi...@apache.org>.</b><hr/><pre> geido commented on code in PR #32989: URL: https://github.com/apache/superset/pull/32989#discussion_r2026964252 ########## superset-frontend/src/features/annotations/AnnotationModal.tsx: ########## @@ -70,7 +71,7 @@ const AnnotationContainer = styled.div` } textarea, - input[type='text'] { + Input { Review Comment: It seems to be intentional at this point? I might be surprised it this actually works :) ########## superset-frontend/src/components/ImportModal/index.tsx: ########## @@ -65,8 +66,8 @@ const StyledInputContainer = styled.div` } } - input, - textarea { + Input, + TextArea { Review Comment: I think this and the ones below were a greedy find and replace? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org For queries about this service, please contact Infrastructure at: users@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org For additional commands, e-mail: notifications-help@superset.apache.org </pre><hr/> <h2>Re: [PR] fix: use Input & TextArea instead of native <input> and <textarea> [superset]</h2> <b>Posted by "geido (via GitHub)" <gi...@apache.org>.</b><hr/><pre> geido commented on code in PR #32989: URL: https://github.com/apache/superset/pull/32989#discussion_r2033759400 ########## superset-frontend/src/components/Chart/DrillDetail/DrillDetailMenuItems.test.tsx: ########## @@ -396,7 +396,7 @@ test('context menu for supported chart, dimensions, filter B', async () => { await expectDrillToDetailByDimension(filterB); }); -test('context menu for supported chart, dimensions, all filters', async () => { +test.skip('context menu for supported chart, dimensions, all filters', async () => { Review Comment: I think I have fixed this in some other PR. I can unskip it later. ########## superset-frontend/src/explore/components/DatasourcePanel/index.tsx: ########## @@ -276,18 +277,20 @@ export default function DataSourcePanel({ datasource.type && saveableDatasets[datasource.type as keyof typeof saveableDatasets]; + const theme = useTheme(); const mainBody = useMemo( () => ( <> - <Input - allowClear - onChange={evt => { - setInputValue(evt.target.value); - }} - value={inputValue} - className="form-control input-md" - placeholder={t('Search Metrics & Columns')} - /> + <div style={{ padding: theme.sizeUnit * 4 }}> Review Comment: Should we use a `Space` or `Flex` component for this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org For queries about this service, please contact Infrastructure at: users@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org For additional commands, e-mail: notifications-help@superset.apache.org </pre><hr/> </body> </html>