[jira] [Commented] (MATH-758) Fields which could be private and/or final

["Gilles (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MATH-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15283629#comment-15283629 ] 

Gilles commented on MATH-758:
-----------------------------

Can we resolve this issue?

It is relatively old. Some concrete cases reported have been handled.  Others have disappeared with their deprecated classes. In some cases, the problem runs deeper (cf. MATH-1228).

The general principle is always valid, and should be integrated in the design unless there is reason (to be documented) not to.
It would be clearer to list each remaining issue of this type in its own JIRA report.


> Fields which could be private and/or final
> ------------------------------------------
>
>                 Key: MATH-758
>                 URL: https://issues.apache.org/jira/browse/MATH-758
>             Project: Commons Math
>          Issue Type: Improvement
>            Reporter: Sebb
>             Fix For: 4.0
>
>
> BaseAbstractUnivariateIntegrator has several fields that are not currently changed after construction and could be final:
> protected double absoluteAccuracy;
> protected double relativeAccuracy;
> protected int minimalIterationCount;
> protected Incrementor iterations;
> protected Incrementor evaluations;
> These all have getters as well, so could also be made private.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)