You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@submarine.apache.org by ji...@apache.org on 2020/12/16 15:34:13 UTC
[submarine] branch master updated: SUBMARINE-694. Some of the
interfaces are defined incorrectly as classes
This is an automated email from the ASF dual-hosted git repository.
jiwq pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/submarine.git
The following commit(s) were added to refs/heads/master by this push:
new 78f3e74 SUBMARINE-694. Some of the interfaces are defined incorrectly as classes
78f3e74 is described below
commit 78f3e74b7de1ec51cf2ae8e6f4247975557f0f5a
Author: ByronHsu <by...@gmail.com>
AuthorDate: Tue Dec 8 16:11:20 2020 +0800
SUBMARINE-694. Some of the interfaces are defined incorrectly as classes
### What is this PR for?
Correct the wrong definition in interfaces/.
### What type of PR is it?
[Improvement]
### What is the Jira issue?
https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-694
### How should this be tested?
Author: ByronHsu <by...@gmail.com>
Closes #471 from ByronHsu/SUBMARINE-694 and squashes the following commits:
c78fdd0 [ByronHsu] Fix interface
---
.../workbench-web/src/app/interfaces/environment-info.ts | 2 +-
.../workbench-web/src/app/interfaces/experiment-info.ts | 2 +-
.../workbench-web/src/app/interfaces/notebook-info.ts | 2 +-
.../workbench-web/src/app/interfaces/notebook-spec.ts | 8 ++++----
4 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/submarine-workbench/workbench-web/src/app/interfaces/environment-info.ts b/submarine-workbench/workbench-web/src/app/interfaces/environment-info.ts
index 80ba127..7ff369c 100644
--- a/submarine-workbench/workbench-web/src/app/interfaces/environment-info.ts
+++ b/submarine-workbench/workbench-web/src/app/interfaces/environment-info.ts
@@ -19,7 +19,7 @@
import { EnvironmentSpec } from '@submarine/interfaces/environment-spec';
-export class Environment {
+export interface Environment {
environmentId: string;
environmentSpec: EnvironmentSpec;
}
diff --git a/submarine-workbench/workbench-web/src/app/interfaces/experiment-info.ts b/submarine-workbench/workbench-web/src/app/interfaces/experiment-info.ts
index feb9c20..b82fa86 100644
--- a/submarine-workbench/workbench-web/src/app/interfaces/experiment-info.ts
+++ b/submarine-workbench/workbench-web/src/app/interfaces/experiment-info.ts
@@ -19,7 +19,7 @@
import { ExperimentSpec } from '@submarine/interfaces/experiment-spec';
-export class ExperimentInfo {
+export interface ExperimentInfo {
experimentId: string;
name: string;
uid: string;
diff --git a/submarine-workbench/workbench-web/src/app/interfaces/notebook-info.ts b/submarine-workbench/workbench-web/src/app/interfaces/notebook-info.ts
index fbd39f7..91a8d21 100644
--- a/submarine-workbench/workbench-web/src/app/interfaces/notebook-info.ts
+++ b/submarine-workbench/workbench-web/src/app/interfaces/notebook-info.ts
@@ -20,7 +20,7 @@
import { Url } from 'url';
import { NotebookSpec } from '@submarine/interfaces/notebook-spec';
-export class Notebook {
+export interface Notebook {
notebookId: string;
name: string;
uid: string;
diff --git a/submarine-workbench/workbench-web/src/app/interfaces/notebook-spec.ts b/submarine-workbench/workbench-web/src/app/interfaces/notebook-spec.ts
index e849a84..4d70a64 100644
--- a/submarine-workbench/workbench-web/src/app/interfaces/notebook-spec.ts
+++ b/submarine-workbench/workbench-web/src/app/interfaces/notebook-spec.ts
@@ -17,19 +17,19 @@
* under the License.
*/
-export class NotebookSpec {
+export interface NotebookSpec {
meta: Meta;
environment: Environment;
spec: Spec;
}
-export class Meta {
+export interface Meta {
name: string;
namespace: string;
ownerId: string;
}
-export class Environment {
+export interface Environment {
name: string;
dockerImage: string;
kernelSpec: {
@@ -41,7 +41,7 @@ export class Environment {
image: string;
}
-export class Spec {
+export interface Spec {
envVars?: {
[key: string]: string;
};
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org