[GitHub] [hadoop-ozone] hanishakoneru commented on a change in pull request #1149: HDDS-3878. Make OMHA serviceID optional if one (but only one) is defined in the config

[GitBox <gi...@apache.org>]

hanishakoneru commented on a change in pull request #1149:
URL: https://github.com/apache/hadoop-ozone/pull/1149#discussion_r468020910



##########
File path: hadoop-ozone/dist/src/main/compose/ozone-om-ha/test_disabled.sh
##########
@@ -1,41 +0,0 @@
-#!/usr/bin/env bash
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements.  See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership.  The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License.  You may obtain a copy of the License at
-#

Review comment:
       @elek sorry for jumping into the discussion late. I am working on fixing the robot tests for HA functionality (the old tests covering the restarts and failovers). 
   Instead of removing those files altogether, can create another dir for the new docker compose - _ozone-ha-basic_ or something. Or rename the old compose dir to something else. 
   
   As for changing the life-cycle test to start/stop services, I am open to discuss a better approach. But I guess we can keep that for a different thread.
   
   Thanks @bharatviswa504 for bringing it to my notice.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org