[GitHub] dawidwys commented on a change in pull request #7371: [FLINK-11224][scala-shell] Log is missing in scala-shell

[GitBox <gi...@apache.org>]

dawidwys commented on a change in pull request #7371: [FLINK-11224][scala-shell] Log is missing in scala-shell
URL: https://github.com/apache/flink/pull/7371#discussion_r246718103
 
 

 ##########
 File path: flink-scala-shell/start-script/start-scala-shell.sh
 ##########
 @@ -82,13 +82,25 @@ do
     fi
 done
 
+if [ "$FLINK_IDENT_STRING" = "" ]; then
+        FLINK_IDENT_STRING="$USER"
+fi
+
 log_setting=""
 
-if [[ $1 = "yarn" ]]
+if [[ $1 = "local" ]]
+then
+    log=$FLINK_LOG_DIR/flink-$FLINK_IDENT_STRING-scala-shell-local-$HOSTNAME.log
+    log_setting="-Dlog.file="$log" -Dlog4j.configuration=file:"$FLINK_CONF_DIR"/log4j.properties -Dlogback.configurationFile=file:"$FLINK_CONF_DIR"/logback.xml"
+elif [[ $1 = "remote" ]]
+then
+    log=$FLINK_LOG_DIR/flink-$FLINK_IDENT_STRING-scala-shell-remote-$HOSTNAME.log
 
 Review comment:
   Could we unify setting the log parameters? They differ very slightly.
   How about we have a common definition:
   
   ```
   log=$FLINK_LOG_DIR/flink-$FLINK_IDENT_STRING-scala-shell-$MODE-$HOSTNAME.log
   log_setting="-Dlog.file="$log" -Dlog4j.configuration=file:"$FLINK_CONF_DIR"/$LOG4J_CONFIG -Dlogback.configurationFile=file:"$FLINK_CONF_DIR"/$LOGBACK_CONFIG"
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services