You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jackrabbit.apache.org by GitBox <gi...@apache.org> on 2022/03/09 11:05:20 UTC

[GitHub] [jackrabbit-oak] jelmini commented on a change in pull request #510: OAK-9713 sas uri support in oak-upgrade

jelmini commented on a change in pull request #510:
URL: https://github.com/apache/jackrabbit-oak/pull/510#discussion_r822533815



##########
File path: oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureUtilities.java
##########
@@ -116,6 +116,12 @@ public static CloudBlobDirectory cloudBlobDirectoryFrom(String connection, Strin
 
         return container.getDirectoryReference(dir);
     }
+    public static CloudBlobDirectory cloudBlobDirectoryFromSasUri(String connection, String containerName,

Review comment:
       @mattvryan This class seem to be exported and is accessed from the `oak-upgrade` module. However, I don't think it's creating a security issue. This class just wraps the Azure SDK. If someone has valid credentials, then it could just as well use the Azure SDK directly to successfully connect.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org