[GitHub] [couchdb] nickva edited a comment on pull request #3569: Use the last commit result even when there are intermediate retries

[GitBox <gi...@apache.org>]

nickva edited a comment on pull request #3569:
URL: https://github.com/apache/couchdb/pull/3569#issuecomment-844234395


   @iilyak Oh good question. 
   
   I think it should always be the last result because as soon as there is at least one `commit_unknown_result` result in the sequence of retries, we will always try to return that result to the user, and not run the transaction closure again https://github.com/apache/couchdb/blob/e5699e5c10bd0131ab9fe3a04bcc1568c1a16186/src/fabric/src/fabric2_fdb.erl#L186
   
   But when we try to return the last result we still have to perform a few FDB operations which would also be an area where retries would be thrown, for example here https://github.com/apache/couchdb/blob/e5699e5c10bd0131ab9fe3a04bcc1568c1a16186/src/fabric/src/fabric2_fdb.erl#L2024 and we don't want those retryable errors to reset the fact that we're still have a commit_unknown_result to handle.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org