You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by robert3005 <gi...@git.apache.org> on 2017/01/13 12:55:48 UTC

[GitHub] spark pull request #16575: [SPARK-19213] DatasourceScanExec uses runtime spa...

GitHub user robert3005 opened a pull request:

    https://github.com/apache/spark/pull/16575

    [SPARK-19213] DatasourceScanExec uses runtime sparksession

    ## What changes were proposed in this pull request?
    
    Physical plan for hadoop fs relation uses active session at the moment of execution
    
    ## How was this patch tested?
    
    Tests added to cover the behaviour

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/robert3005/spark rk/datasourcexec-uses-activesession

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/16575.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #16575
    
----
commit 14020eb89ace35db58c60cbba02db008f699e79a
Author: Robert Kruszewski <ro...@palantir.com>
Date:   2017-01-11T18:19:56Z

    DatasourceScanExec uses runtime sparksession

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #16575: [SPARK-19213] DatasourceScanExec uses runtime sparksessi...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/16575
  
    Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #16575: [SPARK-19213] DatasourceScanExec uses runtime sparksessi...

Posted by hvanhovell <gi...@git.apache.org>.

Github user hvanhovell commented on the issue:

    https://github.com/apache/spark/pull/16575
  
    @robert3005 why is this needed?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #16575: [SPARK-19213] DatasourceScanExec uses runtime sparksessi...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/16575
  
    **[Test build #3530 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3530/testReport)** for PR 16575 at commit [`eb2638f`](https://github.com/apache/spark/commit/eb2638f0e8e199af60969278a03db8dca0301c9f).
     * This patch **fails to build**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #16575: [SPARK-19213] DatasourceScanExec uses runtime sparksessi...

Posted by robert3005 <gi...@git.apache.org>.

Github user robert3005 commented on the issue:

    https://github.com/apache/spark/pull/16575
  
    Removed the caching logic. It was there since I wasn't sure how often we call inputRDDs and how many times the resulting rdd would get created overall since it's a def now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #16575: [SPARK-19213] DatasourceScanExec uses runtime sparksessi...

Posted by ash211 <gi...@git.apache.org>.

Github user ash211 commented on the issue:

    https://github.com/apache/spark/pull/16575
  
    @hvanhovell does that description make sense?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #16575: [SPARK-19213] DatasourceScanExec uses runtime sparksessi...

Posted by gatorsmile <gi...@git.apache.org>.

Github user gatorsmile commented on the issue:

    https://github.com/apache/spark/pull/16575
  
    retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #16575: [SPARK-19213] DatasourceScanExec uses runtime sparksessi...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/16575
  
    **[Test build #72122 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72122/testReport)** for PR 16575 at commit [`aaddaa1`](https://github.com/apache/spark/commit/aaddaa1fc5705003e902053f9d9328fdb7fec10e).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #16575: [SPARK-19213] DatasourceScanExec uses runtime sparksessi...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/16575
  
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #16575: [SPARK-19213] DatasourceScanExec uses runtime sparksessi...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/16575
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72122/
    Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #16575: [SPARK-19213] DatasourceScanExec uses runtime sparksessi...

Posted by robert3005 <gi...@git.apache.org>.

Github user robert3005 commented on the issue:

    https://github.com/apache/spark/pull/16575
  
    This was posted mostly to get comments on what's the expected behaviour. What's unclear is whether dataset can be shared across sparksessions and if so what are the semantics and behaviour of it. It seems off to me that physical plan of hadoopfsrelation will use sparksession from the moment when it was defined. In cases where sparksession is bound to physical plans we can use Dataset.ofRows to swap sparksession from logical plan but for hadoopfsrelation that won't work. I'd think FileSourceScanExec would at least use the session from the moment of execution (on from SparkPlan). However, if we can share datasets across sessions then it makes sense to not tie the session to concrete physical plan but fetch it every time the plan gets executed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #16575: [SPARK-19213] DatasourceScanExec uses runtime sparksessi...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/16575
  
    **[Test build #3530 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3530/testReport)** for PR 16575 at commit [`eb2638f`](https://github.com/apache/spark/commit/eb2638f0e8e199af60969278a03db8dca0301c9f).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #16575: [SPARK-19213] DatasourceScanExec uses runtime sparksessi...

Posted by hvanhovell <gi...@git.apache.org>.

Github user hvanhovell commented on the issue:

    https://github.com/apache/spark/pull/16575
  
    I suppose it makes sense. The only thing I am wondering if this doesn't subtly breaks things. I am certain that some weirdness is to be expected with respect to session local configurations. For instance the plan could be analyzed under one set of configurations and be executed under a different set. I do think that we should consistent.
    
    @robert3005 could you revert all the caching logic which is currently part of this PR, and just make this about SparkSessions?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org