[jira] [Commented] (ACCUMULO-2558) Improve unit test coverage for server gc classes

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ACCUMULO-2558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13962264#comment-13962264 ] 

ASF subversion and git services commented on ACCUMULO-2558:
-----------------------------------------------------------

Commit 88f24d2323efd1aa33de1bf2cd5a0241cbd78306 in accumulo's branch refs/heads/1.6.0-SNAPSHOT from [~bhavanki]
[ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=88f24d2 ]

ACCUMULO-2558 Add unit tests for server/gc

Code changes accompanying unit tests:
- visibility of methods under test changed from private to package
- some methods refactored to take arguments, to permit testability
- GarbageCollectWriteAheadLogs.isUUID() improved to check for null and to check
  length of potential UUID, since UUID.fromString() will accept UUIDs with extraneous
  leading zeroes in components
- SimpleGarbageCollector.getZooLock() finds ZK root using instance field of class
  instead of calling HdfsZooInstance.getInstance() again
- SimpleGarbageCollector.init() no longer declares throwing IOException


> Improve unit test coverage for server gc classes
> ------------------------------------------------
>
>                 Key: ACCUMULO-2558
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2558
>             Project: Accumulo
>          Issue Type: Test
>          Components: gc, test
>            Reporter: Bill Havanki
>            Assignee: Bill Havanki
>            Priority: Minor
>              Labels: gc, unit-test
>
> Goals for server base project coverage:
> * branches 36% -> 50%
> * methods 18% -> 30%
> * classes 10% -> 50%



--
This message was sent by Atlassian JIRA
(v6.2#6252)