You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opennlp.apache.org by sm...@apache.org on 2020/01/25 18:08:59 UTC

[opennlp] branch master updated: Add default value for pi (#366)

This is an automated email from the ASF dual-hosted git repository.

smarthi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/opennlp.git


The following commit(s) were added to refs/heads/master by this push:
     new 5bfe9db  Add default value for pi (#366)
5bfe9db is described below

commit 5bfe9dbf1c7180b2f435bfda52b1d399172f5137
Author: Jānis Šlapiņš <ja...@inbox.lv>
AuthorDate: Sat Jan 25 20:08:50 2020 +0200

    Add default value for pi (#366)
    
    Avoid a NullPointerException when pmap does not contain a feature
---
 .../opennlp/tools/ml/perceptron/SimplePerceptronSequenceTrainer.java    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/opennlp-tools/src/main/java/opennlp/tools/ml/perceptron/SimplePerceptronSequenceTrainer.java b/opennlp-tools/src/main/java/opennlp/tools/ml/perceptron/SimplePerceptronSequenceTrainer.java
index b812836..6b94b70 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/ml/perceptron/SimplePerceptronSequenceTrainer.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/ml/perceptron/SimplePerceptronSequenceTrainer.java
@@ -303,7 +303,7 @@ public class SimplePerceptronSequenceTrainer extends AbstractEventModelSequenceT
         }
         for (int oi = 0; oi < numOutcomes; oi++) {
           for (String feature : featureCounts.get(oi).keySet()) {
-            int pi = pmap.get(feature);
+            int pi = pmap.getOrDefault(feature, -1);
             if (pi != -1) {
               //System.err.println(si+" "+outcomeLabels[oi]+" "+feature+" "+featureCounts[oi].get(feature));
               params[pi].updateParameter(oi, featureCounts.get(oi).get(feature));