You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/05/27 00:12:19 UTC
[GitHub] [iceberg] amogh-jahagirdar opened a new pull request, #4878: API: Cleanup to avoid unnecessary boxing in equality check by comparing snapshotID via ==
amogh-jahagirdar opened a new pull request, #4878:
URL: https://github.com/apache/iceberg/pull/4878
Cleanup to avoid unnecessary boxing in equality check by comparing snapshotID via ==
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on pull request #4878: API: Avoid unnecessary boxing in SnapshotRef equality check by comparing snapshotID via ==
Posted by GitBox <gi...@apache.org>.
kbendick commented on PR #4878:
URL: https://github.com/apache/iceberg/pull/4878#issuecomment-1139763462
Thanks @amogh-jahagirdar and @jackye1995! If we find other places then we can update them later. Not a high priority issue.
I think there's some code in `MetadataUpdate` that uses `SnapshotRef`, but also with a `name` field and that's where it's copied (it came to me in the night). So I'll check and update it if so.
More then the performance gains, I think the use of primitives and treating them as such signifies something to the reader (especially given we don't tend to use `Optional`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on pull request #4878: API: Cleanup SnapshotRef to avoid unnecessary boxing in equality check by comparing snapshotID via ==
Posted by GitBox <gi...@apache.org>.
kbendick commented on PR #4878:
URL: https://github.com/apache/iceberg/pull/4878#issuecomment-1139223542
I believe there are other places that do the same equality check. Want to handle them or leave that as a follow up issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] amogh-jahagirdar commented on pull request #4878: API: Cleanup SnapshotRef to avoid unnecessary boxing in equality check by comparing snapshotID via ==
Posted by GitBox <gi...@apache.org>.
amogh-jahagirdar commented on PR #4878:
URL: https://github.com/apache/iceberg/pull/4878#issuecomment-1139249187
As far as the error prone https://errorprone.info/bugpattern/ObjectEqualsForPrimitives check goes I'm not seeing any other cases when I compile, so this seems to be the only place where this applies. Let me know if I'm missing some cases @kbendick!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] amogh-jahagirdar commented on pull request #4878: API: Cleanup SnapshotRef to avoid unnecessary boxing in equality check by comparing snapshotID via ==
Posted by GitBox <gi...@apache.org>.
amogh-jahagirdar commented on PR #4878:
URL: https://github.com/apache/iceberg/pull/4878#issuecomment-1139237501
> I believe there are other places that do the same equality check. Want to handle them or leave that as a follow up issue?
Good point! This case was just something I noticed in the warning logs when building, let me double check if there are any others. If there are, I think I may as well tackle them here!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 merged pull request #4878: API: Cleanup SnapshotRef to avoid unnecessary boxing in equality check by comparing snapshotID via ==
Posted by GitBox <gi...@apache.org>.
jackye1995 merged PR #4878:
URL: https://github.com/apache/iceberg/pull/4878
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org