You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2018/11/09 14:37:59 UTC

[GitHub] ScienJus edited a comment on issue #1892: Custom HystrixConcurrencyStrategy doesn't work when using hystrix plugin.

ScienJus edited a comment on issue #1892: Custom HystrixConcurrencyStrategy doesn't work when using hystrix plugin.
URL: https://github.com/apache/incubator-skywalking/issues/1892#issuecomment-437375652
 
 
   > Look like it should, do you have case to try?
   
   Sure, it's easy to create a case.
   
   > Do you mean SWHystrixConcurrencyStrategyWrapper? I don't think it uses ASM in any way.
   
   In the first option, `HystrixConcurrencyStrategyInterceptor` will only register `SWHystrixConcurrencyStrategyWrapper` once, and never modify the result (the code snippet in the first option), so is the `HystrixConcurrencyStrategyInterceptor`(uses ASM) necessary? Or just need a static initialization method? (Can be discussed after I create the pr)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services