You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/03/21 07:41:17 UTC
[GitHub] [incubator-dolphinscheduler] songquanhe-gitstudy opened a new pull
request #2257: sqlTask failed to run
songquanhe-gitstudy opened a new pull request #2257: sqlTask failed to run
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2257
## *Tips*
- *Thanks very much for contributing to Apache DolphinScheduler.*
- *Please review https://dolphinscheduler.apache.org/en-us/community/index.html before opening a pull request.*
## What is the purpose of the pull request
When running the sql task it reports an error: "No operations allowed after statement closed". After the change, the sql task can run normally.
## Brief change log
Do not close it before the prepareStatement executes the query sql.
## Verify this pull request
After the code is modified and the sql task is executed normally after testing, the following log: "[taskAppId = TASK-4-41-71]: [376]-prepare statement replace sql: com.mysql.jdbc.JDBC4PreparedStatement@462aef8a: select * from t_gs_group;
[INFO] 2020-03-21 14: 59: 37.098 org.apache.dolphinscheduler.server.worker.runner.TaskScheduleThread: [160]-task instance id: 71, task final status: SUCCESS ”.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] xingchun-chen commented on issue
#2257: sqlTask failed to run
Posted by GitBox <gi...@apache.org>.
xingchun-chen commented on issue #2257: sqlTask failed to run
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2257#issuecomment-602136006
e2e code run fails because your dev code is old, please merge the dev code and push again
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue
#2257: sqlTask failed to run
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on issue #2257: sqlTask failed to run
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2257#issuecomment-602010107
SonarCloud Quality Gate failed.
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2257&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/E.png' alt='E' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2257&resolved=false&types=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2257&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2257&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2257&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2257&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2257&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2257&resolved=false&types=SECURITY_HOTSPOT) to review)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2257&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2257&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2257&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2257&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2257&metric=new_coverage&view=list)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2257&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2257&metric=new_duplicated_lines_density&view=list)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] songquanhe-gitstudy closed pull
request #2257: sqlTask failed to run
Posted by GitBox <gi...@apache.org>.
songquanhe-gitstudy closed pull request #2257: sqlTask failed to run
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2257
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #2257:
sqlTask failed to run
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #2257: sqlTask failed to run
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2257#issuecomment-602009807
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2257?src=pr&el=h1) Report
> Merging [#2257](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2257?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/f66c21de1efd0d4cad8eef7b1727b612b3ed3092&el=desc) will **increase** coverage by `0.58%`.
> The diff coverage is `19.37%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2257?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #2257 +/- ##
============================================
+ Coverage 29.84% 30.43% +0.58%
- Complexity 1631 1663 +32
============================================
Files 336 337 +1
Lines 17810 17830 +20
Branches 2238 2238
============================================
+ Hits 5315 5426 +111
+ Misses 11931 11847 -84
+ Partials 564 557 -7
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2257?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../org/apache/dolphinscheduler/common/Constants.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2257/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL0NvbnN0YW50cy5qYXZh) | `82.35% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...nscheduler/common/task/mr/MapreduceParameters.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2257/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3Rhc2svbXIvTWFwcmVkdWNlUGFyYW1ldGVycy5qYXZh) | `3.22% <0.00%> (-0.23%)` | `1.00 <0.00> (ø)` | |
| [...r/common/utils/process/ProcessBuilderForWin32.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2257/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL3Byb2Nlc3MvUHJvY2Vzc0J1aWxkZXJGb3JXaW4zMi5qYXZh) | `46.00% <0.00%> (ø)` | `32.00 <0.00> (ø)` | |
| [...hinscheduler/dao/datasource/PostgreDataSource.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2257/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2RhdGFzb3VyY2UvUG9zdGdyZURhdGFTb3VyY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...e/dolphinscheduler/dao/entity/ProcessInstance.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2257/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9Qcm9jZXNzSW5zdGFuY2UuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ache/dolphinscheduler/dao/entity/TaskInstance.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2257/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9UYXNrSW5zdGFuY2UuamF2YQ==) | `3.50% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...hinscheduler/dao/upgrade/PostgresqlUpgradeDao.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2257/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL3VwZ3JhZGUvUG9zdGdyZXNxbFVwZ3JhZGVEYW8uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...dolphinscheduler/dao/utils/PostgrePerformance.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2257/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL3V0aWxzL1Bvc3RncmVQZXJmb3JtYW5jZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...heduler/server/master/runner/MasterExecThread.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2257/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ydW5uZXIvTWFzdGVyRXhlY1RocmVhZC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...scheduler/server/worker/task/mr/MapReduceTask.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2257/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL21yL01hcFJlZHVjZVRhc2suamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [40 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2257/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2257?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2257?src=pr&el=footer). Last update [1658176...a3126e6](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2257?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services