You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by GitBox <gi...@apache.org> on 2021/10/30 17:39:25 UTC
[GitHub] [ant] twogee opened a new pull request #166: Support Jakarta Mail in MailLogger
twogee opened a new pull request #166:
URL: https://github.com/apache/ant/pull/166
Unfortunately, the code is duplicated due to different logging in different objects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] [ant] bodewig commented on pull request #166: Support Jakarta Mail in MailLogger
Posted by GitBox <gi...@apache.org>.
bodewig commented on pull request #166:
URL: https://github.com/apache/ant/pull/166#issuecomment-955673433
In the special case of a logger it may be even preferable to not log any message at all as the message would in turn be logged to the same logger again and may never become visible anywhere. I see the existing code has a `log` statement but I wonder whether this is just an oversight. There are usages of `System.err/out` which may be the better choice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] [ant] twogee commented on pull request #166: Support Jakarta Mail in MailLogger
Posted by GitBox <gi...@apache.org>.
twogee commented on pull request #166:
URL: https://github.com/apache/ant/pull/166#issuecomment-955740651
I reason that it might be preferable to have those messages in the log at higher verbosity. Would adding a new interface to provide implementations of log create backwards compatibility problems?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] [ant] twogee edited a comment on pull request #166: Support Jakarta Mail in MailLogger
Posted by GitBox <gi...@apache.org>.
twogee edited a comment on pull request #166:
URL: https://github.com/apache/ant/pull/166#issuecomment-955740651
I reason that it might be preferable to have those messages in the log at higher verbosity. Would adding a new interface to provide implementations of the log method create backwards compatibility problems?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] [ant] bodewig commented on pull request #166: Support Jakarta Mail in MailLogger
Posted by GitBox <gi...@apache.org>.
bodewig commented on pull request #166:
URL: https://github.com/apache/ant/pull/166#issuecomment-962452645
given this all happens in `buildFinished` and it will not be called again after that, my fear of causing a cycle is unfounded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] [ant] bodewig merged pull request #166: Support Jakarta Mail in MailLogger
Posted by GitBox <gi...@apache.org>.
bodewig merged pull request #166:
URL: https://github.com/apache/ant/pull/166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org