You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/07/28 13:58:54 UTC

[GitHub] [tvm] valmat07 opened a new pull request, #12216: [CI] Fix build android rpc failure in CI

valmat07 opened a new pull request, #12216:
URL: https://github.com/apache/tvm/pull/12216

   android_rpc build problem: https://github.com/apache/tvm/issues/12191
   
   The problem with the build appeared due to the fact that the `ANDROID_NDK_HOME` environment variable was removed in the current version of github actions. 
   https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu2004-Readme.md
   
   But this variable is used here:
   
   https://github.com/apache/tvm/blob/ee319d9d23c80091da9c4fb764b1e6d49d462714/.github/workflows/main.yml#L122-L127
   
   Now only `ANDROID_NDK_LATEST_HOME` is available for ndk.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] driazati merged pull request #12216: [CI] Fix build android rpc failure in CI

Posted by GitBox <gi...@apache.org>.
driazati merged PR #12216:
URL: https://github.com/apache/tvm/pull/12216


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] driazati commented on a diff in pull request #12216: [CI] Fix build android rpc failure in CI

Posted by GitBox <gi...@apache.org>.
driazati commented on code in PR #12216:
URL: https://github.com/apache/tvm/pull/12216#discussion_r932503538


##########
.github/workflows/main.yml:
##########
@@ -122,7 +122,7 @@ jobs:
       - name: Build android_rpc
         working-directory: apps/android_rpc
         run: |
-          export PATH="${ANDROID_NDK_HOME}:$PATH"
+          export PATH="${ANDROID_NDK_LATEST_HOME}:$PATH"

Review Comment:
   Can you also add `set -eux` to all the inline scripts so we get errors about unbound variables if something changes in the future?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org