You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/08/06 03:58:29 UTC

[GitHub] [dubbo-go] Leospard commented on a diff in pull request #1963: [Ftr] Enhance ServiceDefinition in MetadataService

Leospard commented on code in PR #1963:
URL: https://github.com/apache/dubbo-go/pull/1963#discussion_r939478970


##########
metadata/definition/definition.go:
##########
@@ -70,8 +71,8 @@ func (def *ServiceDefinition) String() string {
 
 // FullServiceDefinition is the describer of service definition with parameters
 type FullServiceDefinition struct {
+	Parameters map[string]string

Review Comment:
   主要是和java对齐,java里MetadataService服务提供的ServideDefinition是包含url Parameters参数的



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org