You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2017/06/21 02:26:49 UTC
[kudu-CR] external mini cluster: allow more flags on restart
Andrew Wong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7242
Change subject: external_mini_cluster: allow more flags on restart
......................................................................
external_mini_cluster: allow more flags on restart
This patch allows EMCs to be restarted with additional flags. This helps
test a cluster's behavior at startup in the presence of flags the
emulate various failures.
Change-Id: Ifa588eab70880ffb8680097ef7f4292e2f638fed
---
M src/kudu/integration-tests/external_mini_cluster.cc
M src/kudu/integration-tests/external_mini_cluster.h
2 files changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/42/7242/1
--
To view, visit http://gerrit.cloudera.org:8080/7242
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifa588eab70880ffb8680097ef7f4292e2f638fed
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR] external mini cluster: allow more flags on restart
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: external_mini_cluster: allow more flags on restart
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7242/4/src/kudu/integration-tests/external_mini_cluster.h
File src/kudu/integration-tests/external_mini_cluster.h:
PS4, Line 437: // Return a pointer to the flags used for this server on restart.
: // Modifying these flags will only take effect on the next restart.
: std::vector<std::string>* mutable_flags() { return &extra_flags_; }
Doesn't this method allow you to do what you want already?
--
To view, visit http://gerrit.cloudera.org:8080/7242
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa588eab70880ffb8680097ef7f4292e2f638fed
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] external mini cluster: allow more flags on restart
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has abandoned this change.
Change subject: external_mini_cluster: allow more flags on restart
......................................................................
Abandoned
Not needed
--
To view, visit http://gerrit.cloudera.org:8080/7242
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: Ifa588eab70880ffb8680097ef7f4292e2f638fed
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] external mini cluster: allow more flags on restart
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change.
Change subject: external_mini_cluster: allow more flags on restart
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7242/4/src/kudu/integration-tests/external_mini_cluster.h
File src/kudu/integration-tests/external_mini_cluster.h:
PS4, Line 437: // Return a pointer to the flags used for this server on restart.
: // Modifying these flags will only take effect on the next restart.
: std::vector<std::string>* mutable_flags() { return &extra_flags_; }
> Doesn't this method allow you to do what you want already?
Yep, looks like it. Thanks
--
To view, visit http://gerrit.cloudera.org:8080/7242
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa588eab70880ffb8680097ef7f4292e2f638fed
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes