You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@shindig.apache.org by lo...@gmail.com on 2009/08/18 19:49:53 UTC

Re: Add caja compatible flash support to shindig

http://codereview.appspot.com/66045/diff/4001/4005
File features/src/main/javascript/features/caja/taming.js (right):

http://codereview.appspot.com/66045/diff/4001/4005#newcode289
Line 289: width: 1,
can these be 0. as is this will occupy some of the layout

http://codereview.appspot.com/66045/diff/4001/4004
File features/src/main/javascript/features/flash/flash.js (right):

http://codereview.appspot.com/66045/diff/4001/4004#newcode123
Line 123: a.href = swfUrl;
why create the href? to have the swf url be resolved?
the swf will invariably be absolute because it is either proxied or it
will be on a different domain than the gadget.

http://codereview.appspot.com/66045/diff/4001/4003
File javascript/container/Bridge.as (right):

http://codereview.appspot.com/66045/diff/4001/4003#newcode1
Line 1: import flash.external.ExternalInterface;
Needs an Apache license

http://codereview.appspot.com/66045/diff/4001/4003#newcode11
Line 11: _root.message.text += "callSWF\n";
condition check to enable logging based on swf params.

can this call out to gadgets.log instead? logging the method would also
be useful.

http://codereview.appspot.com/66045