You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/03/13 15:29:19 UTC
[GitHub] [hbase] virajjasani opened a new pull request #1286: HBASE-23977 :
Resolve flakes present in TestSlowLogRecorder
virajjasani opened a new pull request #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
URL: https://github.com/apache/hbase/pull/1286
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani commented on issue #1286: HBASE-23977 : Resolve
flakes present in TestSlowLogRecorder
Posted by GitBox <gi...@apache.org>.
virajjasani commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
URL: https://github.com/apache/hbase/pull/1286#issuecomment-598790942
btw I am returning true in `waitFor()` because `confirmPayloadParams` is anyways going to throw AssertError if match is not found
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani merged pull request #1286: HBASE-23977 :
Resolve flakes present in TestSlowLogRecorder
Posted by GitBox <gi...@apache.org>.
virajjasani merged pull request #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
URL: https://github.com/apache/hbase/pull/1286
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani commented on a change in pull request #1286:
HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
URL: https://github.com/apache/hbase/pull/1286#discussion_r395452963
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/slowlog/TestSlowLogRecorder.java
##########
@@ -214,29 +234,35 @@ public void testOnlineSlowLogWithHighRecords() throws Exception {
Assert.assertNotEquals(-1, HBASE_TESTING_UTILITY.waitFor(3000,
() -> slowLogRecorder.getSlowLogPayloads(request).size() == 14));
- List<SlowLogPayload> slowLogPayloads = slowLogRecorder.getSlowLogPayloads(request);
- Assert.assertEquals(slowLogPayloads.size(), 14);
-
- // confirm strict order of slow log payloads
- confirmPayloadParams(0, 154, slowLogPayloads);
- confirmPayloadParams(1, 153, slowLogPayloads);
- confirmPayloadParams(2, 152, slowLogPayloads);
- confirmPayloadParams(3, 151, slowLogPayloads);
- confirmPayloadParams(4, 150, slowLogPayloads);
- confirmPayloadParams(5, 149, slowLogPayloads);
- confirmPayloadParams(6, 148, slowLogPayloads);
- confirmPayloadParams(7, 147, slowLogPayloads);
- confirmPayloadParams(8, 146, slowLogPayloads);
- confirmPayloadParams(9, 145, slowLogPayloads);
- confirmPayloadParams(10, 144, slowLogPayloads);
- confirmPayloadParams(11, 143, slowLogPayloads);
- confirmPayloadParams(12, 142, slowLogPayloads);
- confirmPayloadParams(13, 141, slowLogPayloads);
+ Assert.assertNotEquals(-1, HBASE_TESTING_UTILITY.waitFor(3000,
+ () -> {
+ List<SlowLogPayload> slowLogPayloads = slowLogRecorder.getSlowLogPayloads(request);
+ boolean b1 = slowLogPayloads.size() == 14;
+
+ // confirm strict order of slow log payloads
+ boolean b2 = confirmPayloadParams(0, 154, slowLogPayloads);
+ boolean b3 = confirmPayloadParams(1, 153, slowLogPayloads);
+ boolean b4 = confirmPayloadParams(2, 152, slowLogPayloads);
+ boolean b5 = confirmPayloadParams(3, 151, slowLogPayloads);
+ boolean b6 = confirmPayloadParams(4, 150, slowLogPayloads);
+ boolean b7 = confirmPayloadParams(5, 149, slowLogPayloads);
+ boolean b8 = confirmPayloadParams(6, 148, slowLogPayloads);
+ boolean b9 = confirmPayloadParams(7, 147, slowLogPayloads);
+ boolean b10 = confirmPayloadParams(8, 146, slowLogPayloads);
+ boolean b11 = confirmPayloadParams(9, 145, slowLogPayloads);
+ boolean b12 = confirmPayloadParams(10, 144, slowLogPayloads);
+ boolean b13 = confirmPayloadParams(11, 143, slowLogPayloads);
+ boolean b14 = confirmPayloadParams(12, 142, slowLogPayloads);
+ boolean b15 = confirmPayloadParams(13, 141, slowLogPayloads);
+ return b1 && b2 && b3 && b4 && b5 && b6 && b7 && b8 && b9 && b10 && b11
Review comment:
yeah, makes sense, let me take it up. Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani commented on a change in pull request #1286:
HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
URL: https://github.com/apache/hbase/pull/1286#discussion_r393458445
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/slowlog/TestSlowLogRecorder.java
##########
@@ -93,12 +91,14 @@ private static Configuration applySlowLogRecorderConf(int eventSize) {
* @param i index of ringbuffer logs
* @param j data value that was put on index i
* @param slowLogPayloads list of payload retrieved from {@link SlowLogRecorder}
+ * @return if actual values are as per expectations
*/
- private void confirmPayloadParams(int i, int j, List<SlowLogPayload> slowLogPayloads) {
+ private boolean confirmPayloadParams(int i, int j, List<SlowLogPayload> slowLogPayloads) {
- Assert.assertEquals(slowLogPayloads.get(i).getClientAddress(), "client_" + j);
- Assert.assertEquals(slowLogPayloads.get(i).getUserName(), "userName_" + j);
- Assert.assertEquals(slowLogPayloads.get(i).getServerClass(), "class_" + j);
+ boolean isClientExpected = slowLogPayloads.get(i).getClientAddress().equals("client_" + j);
Review comment:
I agree but this is just for better readability. Should be fine to keep it this way?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1286: HBASE-23977 :
Resolve flakes present in TestSlowLogRecorder
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
URL: https://github.com/apache/hbase/pull/1286#issuecomment-598892947
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 6s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 6m 2s | master passed |
| +1 :green_heart: | checkstyle | 1m 13s | master passed |
| -1 :x: | spotbugs | 2m 11s | hbase-server in master has 1 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 35s | the patch passed |
| +1 :green_heart: | checkstyle | 1m 14s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | hadoopcheck | 18m 13s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 :green_heart: | spotbugs | 2m 27s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 13s | The patch does not generate ASF License warnings. |
| | | 45m 29s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/3/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1286 |
| Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle |
| uname | Linux 492902fbb377 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / b9e74e0b0a |
| spotbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/3/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html |
| Max. process+thread count | 83 (vs. ulimit of 10000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/3/console |
| versions | git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani commented on issue #1286: HBASE-23977 : Resolve
flakes present in TestSlowLogRecorder
Posted by GitBox <gi...@apache.org>.
virajjasani commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
URL: https://github.com/apache/hbase/pull/1286#issuecomment-598790294
> Maybe try inserting an intentional delay into the machinery around the ringbuffer, so as to tease out a timing bug?
It's not timing bug actually, it's happening asynchronously and we are expecting records in one order before they are even processed.
I just tried `waitFor`, how does it look? @ndimiduk @saintstack
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani removed a comment on issue #1286: HBASE-23977 :
Resolve flakes present in TestSlowLogRecorder
Posted by GitBox <gi...@apache.org>.
virajjasani removed a comment on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
URL: https://github.com/apache/hbase/pull/1286#issuecomment-598790942
btw I am returning true in `waitFor()` because `confirmPayloadParams` is anyways going to throw AssertError if match is not found
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1286: HBASE-23977 :
Resolve flakes present in TestSlowLogRecorder
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
URL: https://github.com/apache/hbase/pull/1286#issuecomment-598874977
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 54s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 48s | master passed |
| +1 :green_heart: | compile | 1m 4s | master passed |
| +1 :green_heart: | shadedjars | 5m 24s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 39s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 55s | the patch passed |
| +1 :green_heart: | compile | 1m 1s | the patch passed |
| +1 :green_heart: | javac | 1m 1s | the patch passed |
| +1 :green_heart: | shadedjars | 5m 22s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 38s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 156m 50s | hbase-server in the patch failed. |
| | | 187m 9s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1286 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 4694ef855af4 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / b9e74e0b0a |
| Default Java | 1.8.0_232 |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/2/testReport/ |
| Max. process+thread count | 4532 (vs. ulimit of 10000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/2/console |
| versions | git=2.17.1 maven=2018-06-17T18:33:14Z) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani commented on a change in pull request #1286:
HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
URL: https://github.com/apache/hbase/pull/1286#discussion_r393458445
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/slowlog/TestSlowLogRecorder.java
##########
@@ -93,12 +91,14 @@ private static Configuration applySlowLogRecorderConf(int eventSize) {
* @param i index of ringbuffer logs
* @param j data value that was put on index i
* @param slowLogPayloads list of payload retrieved from {@link SlowLogRecorder}
+ * @return if actual values are as per expectations
*/
- private void confirmPayloadParams(int i, int j, List<SlowLogPayload> slowLogPayloads) {
+ private boolean confirmPayloadParams(int i, int j, List<SlowLogPayload> slowLogPayloads) {
- Assert.assertEquals(slowLogPayloads.get(i).getClientAddress(), "client_" + j);
- Assert.assertEquals(slowLogPayloads.get(i).getUserName(), "userName_" + j);
- Assert.assertEquals(slowLogPayloads.get(i).getServerClass(), "class_" + j);
+ boolean isClientExpected = slowLogPayloads.get(i).getClientAddress().equals("client_" + j);
Review comment:
I agree but this is just for better readability. Should be fine to keep it this way?
Especially because statements are bit longer than expected and hence these variables can help with better readability?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1286: HBASE-23977 :
Resolve flakes present in TestSlowLogRecorder
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
URL: https://github.com/apache/hbase/pull/1286#issuecomment-598959781
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 49s | Docker mode activated. |
| -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 7m 48s | master passed |
| +1 :green_heart: | compile | 1m 22s | master passed |
| +1 :green_heart: | shadedjars | 5m 43s | branch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 45s | hbase-server in master failed. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 7m 8s | the patch passed |
| +1 :green_heart: | compile | 1m 17s | the patch passed |
| +1 :green_heart: | javac | 1m 17s | the patch passed |
| +1 :green_heart: | shadedjars | 6m 42s | patch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 1m 6s | hbase-server in the patch failed. |
||| _ Other Tests _ |
| -0 :warning: | unit | 158m 50s | hbase-server in the patch failed. |
| | | 194m 20s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1286 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux ebc13981a419 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / b9e74e0b0a |
| Default Java | 2020-01-14 |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/3/testReport/ |
| Max. process+thread count | 4819 (vs. ulimit of 10000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/3/console |
| versions | git=2.17.1 maven=2018-06-17T18:33:14Z) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1286: HBASE-23977 :
Resolve flakes present in TestSlowLogRecorder
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
URL: https://github.com/apache/hbase/pull/1286#issuecomment-598816816
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 32s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 2s | master passed |
| +1 :green_heart: | checkstyle | 1m 7s | master passed |
| -1 :x: | spotbugs | 1m 58s | hbase-server in master has 1 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 6s | the patch passed |
| +1 :green_heart: | checkstyle | 1m 6s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | hadoopcheck | 15m 48s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 :green_heart: | spotbugs | 2m 10s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 16s | The patch does not generate ASF License warnings. |
| | | 39m 54s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/2/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1286 |
| Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle |
| uname | Linux dc55ad896bbe 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / b9e74e0b0a |
| spotbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/2/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html |
| Max. process+thread count | 93 (vs. ulimit of 10000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/2/console |
| versions | git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on a change in pull request #1286:
HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
URL: https://github.com/apache/hbase/pull/1286#discussion_r395328571
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/slowlog/TestSlowLogRecorder.java
##########
@@ -93,12 +91,14 @@ private static Configuration applySlowLogRecorderConf(int eventSize) {
* @param i index of ringbuffer logs
* @param j data value that was put on index i
* @param slowLogPayloads list of payload retrieved from {@link SlowLogRecorder}
+ * @return if actual values are as per expectations
*/
- private void confirmPayloadParams(int i, int j, List<SlowLogPayload> slowLogPayloads) {
+ private boolean confirmPayloadParams(int i, int j, List<SlowLogPayload> slowLogPayloads) {
- Assert.assertEquals(slowLogPayloads.get(i).getClientAddress(), "client_" + j);
- Assert.assertEquals(slowLogPayloads.get(i).getUserName(), "userName_" + j);
- Assert.assertEquals(slowLogPayloads.get(i).getServerClass(), "class_" + j);
+ boolean isClientExpected = slowLogPayloads.get(i).getClientAddress().equals("client_" + j);
Review comment:
It's a style consideration... not a strong concern. I find it easier to read if you did something like
```java
return doThingA()
&& doThingB()
&& doThingC();
```
because in this case, there's no chance for any of them to be accidentally forgotten. Not as important here where there's only 3, but down below you do quite a few, so that's where I think it helps.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani commented on issue #1286: HBASE-23977 : Resolve
flakes present in TestSlowLogRecorder
Posted by GitBox <gi...@apache.org>.
virajjasani commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
URL: https://github.com/apache/hbase/pull/1286#issuecomment-601020460
@ndimiduk @saintstack I just triggered a build and since I have run individual test 50-70 times in loop, let me commit this after QA results.
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani removed a comment on issue #1286: HBASE-23977 :
Resolve flakes present in TestSlowLogRecorder
Posted by GitBox <gi...@apache.org>.
virajjasani removed a comment on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
URL: https://github.com/apache/hbase/pull/1286#issuecomment-598854018
Spotbug in this build has nothing to do with this patch:
```
Return value of putIfAbsent is ignored, but node is reused in org.apache.hadoop.hbase.master.assignment.RegionStates.createRegionStateNode(RegionInfo)
```
Also, I think moving to spotbugs is a recent change, but why unit test is missing from the QA results? @ndimiduk are you aware of any very recent change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani commented on a change in pull request #1286:
HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
URL: https://github.com/apache/hbase/pull/1286#discussion_r393459603
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/slowlog/TestSlowLogRecorder.java
##########
@@ -140,12 +141,16 @@ public void testOnlieSlowLogConsumption() throws Exception {
Assert.assertNotEquals(-1, HBASE_TESTING_UTILITY.waitFor(3000,
() -> slowLogRecorder.getSlowLogPayloads(request).size() == 7));
- slowLogPayloads = slowLogRecorder.getSlowLogPayloads(request);
-
- Assert.assertEquals(slowLogPayloads.size(), 7);
- confirmPayloadParams(0, 7, slowLogPayloads);
- confirmPayloadParams(5, 2, slowLogPayloads);
- confirmPayloadParams(6, 1, slowLogPayloads);
+ Assert.assertNotEquals(-1, HBASE_TESTING_UTILITY.waitFor(3000,
+ () -> {
+ List<SlowLogPayload> slowLogPayloadsList = slowLogRecorder.getSlowLogPayloads(request);
+ Assert.assertEquals(slowLogPayloadsList.size(), 7);
+ boolean b1 = confirmPayloadParams(0, 7, slowLogPayloadsList);
Review comment:
Since we are dealing with parallel processing and we are expecting consumer of ring buffer to get done with ordered events, but based on env, consumer might not be done by the time we expect ordered events present and hence we want to introduce time lag until we get that specific end result of expected ordered list of events in ring buffer. Sounds good @ndimiduk ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on a change in pull request #1286:
HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
URL: https://github.com/apache/hbase/pull/1286#discussion_r395331100
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/slowlog/TestSlowLogRecorder.java
##########
@@ -214,29 +234,35 @@ public void testOnlineSlowLogWithHighRecords() throws Exception {
Assert.assertNotEquals(-1, HBASE_TESTING_UTILITY.waitFor(3000,
() -> slowLogRecorder.getSlowLogPayloads(request).size() == 14));
- List<SlowLogPayload> slowLogPayloads = slowLogRecorder.getSlowLogPayloads(request);
- Assert.assertEquals(slowLogPayloads.size(), 14);
-
- // confirm strict order of slow log payloads
- confirmPayloadParams(0, 154, slowLogPayloads);
- confirmPayloadParams(1, 153, slowLogPayloads);
- confirmPayloadParams(2, 152, slowLogPayloads);
- confirmPayloadParams(3, 151, slowLogPayloads);
- confirmPayloadParams(4, 150, slowLogPayloads);
- confirmPayloadParams(5, 149, slowLogPayloads);
- confirmPayloadParams(6, 148, slowLogPayloads);
- confirmPayloadParams(7, 147, slowLogPayloads);
- confirmPayloadParams(8, 146, slowLogPayloads);
- confirmPayloadParams(9, 145, slowLogPayloads);
- confirmPayloadParams(10, 144, slowLogPayloads);
- confirmPayloadParams(11, 143, slowLogPayloads);
- confirmPayloadParams(12, 142, slowLogPayloads);
- confirmPayloadParams(13, 141, slowLogPayloads);
+ Assert.assertNotEquals(-1, HBASE_TESTING_UTILITY.waitFor(3000,
+ () -> {
+ List<SlowLogPayload> slowLogPayloads = slowLogRecorder.getSlowLogPayloads(request);
+ boolean b1 = slowLogPayloads.size() == 14;
+
+ // confirm strict order of slow log payloads
+ boolean b2 = confirmPayloadParams(0, 154, slowLogPayloads);
+ boolean b3 = confirmPayloadParams(1, 153, slowLogPayloads);
+ boolean b4 = confirmPayloadParams(2, 152, slowLogPayloads);
+ boolean b5 = confirmPayloadParams(3, 151, slowLogPayloads);
+ boolean b6 = confirmPayloadParams(4, 150, slowLogPayloads);
+ boolean b7 = confirmPayloadParams(5, 149, slowLogPayloads);
+ boolean b8 = confirmPayloadParams(6, 148, slowLogPayloads);
+ boolean b9 = confirmPayloadParams(7, 147, slowLogPayloads);
+ boolean b10 = confirmPayloadParams(8, 146, slowLogPayloads);
+ boolean b11 = confirmPayloadParams(9, 145, slowLogPayloads);
+ boolean b12 = confirmPayloadParams(10, 144, slowLogPayloads);
+ boolean b13 = confirmPayloadParams(11, 143, slowLogPayloads);
+ boolean b14 = confirmPayloadParams(12, 142, slowLogPayloads);
+ boolean b15 = confirmPayloadParams(13, 141, slowLogPayloads);
+ return b1 && b2 && b3 && b4 && b5 && b6 && b7 && b8 && b9 && b10 && b11
Review comment:
Yeah, so here's the example where all these intermediate variables make this hard to know it's correct on a quick glance. If it was a chain of `return foo && bar && biz && ...`, it's obvious that all components are considered.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on a change in pull request #1286:
HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
URL: https://github.com/apache/hbase/pull/1286#discussion_r393390573
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/slowlog/TestSlowLogRecorder.java
##########
@@ -93,12 +91,14 @@ private static Configuration applySlowLogRecorderConf(int eventSize) {
* @param i index of ringbuffer logs
* @param j data value that was put on index i
* @param slowLogPayloads list of payload retrieved from {@link SlowLogRecorder}
+ * @return if actual values are as per expectations
*/
- private void confirmPayloadParams(int i, int j, List<SlowLogPayload> slowLogPayloads) {
+ private boolean confirmPayloadParams(int i, int j, List<SlowLogPayload> slowLogPayloads) {
- Assert.assertEquals(slowLogPayloads.get(i).getClientAddress(), "client_" + j);
- Assert.assertEquals(slowLogPayloads.get(i).getUserName(), "userName_" + j);
- Assert.assertEquals(slowLogPayloads.get(i).getServerClass(), "class_" + j);
+ boolean isClientExpected = slowLogPayloads.get(i).getClientAddress().equals("client_" + j);
Review comment:
nit: intermediate boolean values aren't necessary... just return `foo && bar && baz`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1286: HBASE-23977 :
Resolve flakes present in TestSlowLogRecorder
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
URL: https://github.com/apache/hbase/pull/1286#issuecomment-598957434
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 49s | Docker mode activated. |
| -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 6m 18s | master passed |
| +1 :green_heart: | compile | 1m 1s | master passed |
| +1 :green_heart: | shadedjars | 5m 23s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 39s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 55s | the patch passed |
| +1 :green_heart: | compile | 1m 2s | the patch passed |
| +1 :green_heart: | javac | 1m 2s | the patch passed |
| +1 :green_heart: | shadedjars | 5m 17s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 38s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 155m 32s | hbase-server in the patch failed. |
| | | 185m 51s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1286 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux cd2d74d88077 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / b9e74e0b0a |
| Default Java | 1.8.0_232 |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/3/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/3/testReport/ |
| Max. process+thread count | 4536 (vs. ulimit of 10000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/3/console |
| versions | git=2.17.1 maven=2018-06-17T18:33:14Z) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on issue #1286: HBASE-23977 : Resolve
flakes present in TestSlowLogRecorder
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
URL: https://github.com/apache/hbase/pull/1286#issuecomment-598783297
Maybe try inserting an intentional delay into the machinery around the ringbuffer, so as to tease out a timing bug?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani commented on a change in pull request #1286:
HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
URL: https://github.com/apache/hbase/pull/1286#discussion_r393458445
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/slowlog/TestSlowLogRecorder.java
##########
@@ -93,12 +91,14 @@ private static Configuration applySlowLogRecorderConf(int eventSize) {
* @param i index of ringbuffer logs
* @param j data value that was put on index i
* @param slowLogPayloads list of payload retrieved from {@link SlowLogRecorder}
+ * @return if actual values are as per expectations
*/
- private void confirmPayloadParams(int i, int j, List<SlowLogPayload> slowLogPayloads) {
+ private boolean confirmPayloadParams(int i, int j, List<SlowLogPayload> slowLogPayloads) {
- Assert.assertEquals(slowLogPayloads.get(i).getClientAddress(), "client_" + j);
- Assert.assertEquals(slowLogPayloads.get(i).getUserName(), "userName_" + j);
- Assert.assertEquals(slowLogPayloads.get(i).getServerClass(), "class_" + j);
+ boolean isClientExpected = slowLogPayloads.get(i).getClientAddress().equals("client_" + j);
Review comment:
I agree but this is just for better readability. Should be fine to keep it this way?
Especially because statements are bit longer and hence these variables can help with better readability?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1286: HBASE-23977 :
Resolve flakes present in TestSlowLogRecorder
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
URL: https://github.com/apache/hbase/pull/1286#issuecomment-601050421
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 53s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 59s | master passed |
| +1 :green_heart: | compile | 0m 59s | master passed |
| +1 :green_heart: | shadedjars | 5m 6s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 39s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 22s | the patch passed |
| +1 :green_heart: | compile | 0m 59s | the patch passed |
| +1 :green_heart: | javac | 0m 59s | the patch passed |
| +1 :green_heart: | shadedjars | 5m 2s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 36s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 61m 22s | hbase-server in the patch failed. |
| | | 89m 0s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1286 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 212f7107eb72 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 52a04e69c1 |
| Default Java | 1.8.0_232 |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/4/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/4/testReport/ |
| Max. process+thread count | 5957 (vs. ulimit of 10000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/4/console |
| versions | git=2.17.1 maven=2018-06-17T18:33:14Z) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani commented on issue #1286: HBASE-23977 : Resolve
flakes present in TestSlowLogRecorder
Posted by GitBox <gi...@apache.org>.
virajjasani commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
URL: https://github.com/apache/hbase/pull/1286#issuecomment-600247542
Thanks @ndimiduk
Could you please take a look one more time?
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1286: HBASE-23977 :
Resolve flakes present in TestSlowLogRecorder
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
URL: https://github.com/apache/hbase/pull/1286#issuecomment-601032155
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 11s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 6m 14s | master passed |
| +1 :green_heart: | checkstyle | 1m 15s | master passed |
| -1 :x: | spotbugs | 2m 13s | hbase-server in master has 1 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 48s | the patch passed |
| +1 :green_heart: | checkstyle | 1m 12s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | hadoopcheck | 12m 35s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2. |
| +1 :green_heart: | spotbugs | 2m 20s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 13s | The patch does not generate ASF License warnings. |
| | | 40m 22s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/4/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1286 |
| Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle |
| uname | Linux 8a6f316bb852 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 52a04e69c1 |
| spotbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/4/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html |
| Max. process+thread count | 83 (vs. ulimit of 10000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/4/console |
| versions | git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani commented on a change in pull request #1286:
HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
URL: https://github.com/apache/hbase/pull/1286#discussion_r395452871
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/slowlog/TestSlowLogRecorder.java
##########
@@ -140,12 +141,16 @@ public void testOnlieSlowLogConsumption() throws Exception {
Assert.assertNotEquals(-1, HBASE_TESTING_UTILITY.waitFor(3000,
() -> slowLogRecorder.getSlowLogPayloads(request).size() == 7));
- slowLogPayloads = slowLogRecorder.getSlowLogPayloads(request);
-
- Assert.assertEquals(slowLogPayloads.size(), 7);
- confirmPayloadParams(0, 7, slowLogPayloads);
- confirmPayloadParams(5, 2, slowLogPayloads);
- confirmPayloadParams(6, 1, slowLogPayloads);
+ Assert.assertNotEquals(-1, HBASE_TESTING_UTILITY.waitFor(3000,
+ () -> {
+ List<SlowLogPayload> slowLogPayloadsList = slowLogRecorder.getSlowLogPayloads(request);
+ Assert.assertEquals(slowLogPayloadsList.size(), 7);
+ boolean b1 = confirmPayloadParams(0, 7, slowLogPayloadsList);
Review comment:
oops, my bad, I missed `Assert.assertEquals(slowLogPayloadsList.size(), 7);`, this still makes it flakey as it fails. Let me take care of it in Addendum.
Thanks @ndimiduk
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani commented on a change in pull request #1286:
HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
URL: https://github.com/apache/hbase/pull/1286#discussion_r394126999
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/slowlog/TestSlowLogRecorder.java
##########
@@ -140,12 +141,16 @@ public void testOnlieSlowLogConsumption() throws Exception {
Assert.assertNotEquals(-1, HBASE_TESTING_UTILITY.waitFor(3000,
() -> slowLogRecorder.getSlowLogPayloads(request).size() == 7));
- slowLogPayloads = slowLogRecorder.getSlowLogPayloads(request);
-
- Assert.assertEquals(slowLogPayloads.size(), 7);
- confirmPayloadParams(0, 7, slowLogPayloads);
- confirmPayloadParams(5, 2, slowLogPayloads);
- confirmPayloadParams(6, 1, slowLogPayloads);
+ Assert.assertNotEquals(-1, HBASE_TESTING_UTILITY.waitFor(3000,
+ () -> {
+ List<SlowLogPayload> slowLogPayloadsList = slowLogRecorder.getSlowLogPayloads(request);
+ Assert.assertEquals(slowLogPayloadsList.size(), 7);
+ boolean b1 = confirmPayloadParams(0, 7, slowLogPayloadsList);
Review comment:
e.g if we send {1,2,3,4,5,6,7} to RingBuffer of size 8, then all of them are consumed in same order. Now if we send {8,9,10,11}, we expect final output from RingBuffer consumer to be {9,10,11,4,5,6,7,8} (1,2,3 are overridden). However, the reason why we have flakes is because by the time we expect above output, consumer might not have consumed say 10 and 11 and hence actual output would be {9,2,3,4,5,6,7,8}. And hence the failures, so now with waitFor(), we wait until we get ordered output {9,10,11,4,5,6,7,8}, which is why we will wait for all of 8,9,10,11 to be consumed and put in the queue in correct order i.e. no flakes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani commented on issue #1286: HBASE-23977 : Resolve
flakes present in TestSlowLogRecorder
Posted by GitBox <gi...@apache.org>.
virajjasani commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
URL: https://github.com/apache/hbase/pull/1286#issuecomment-598796148
> There's a utility method `waitUntil` that lets you wait for a condition to occur, or timeout. Check it's return value for the timeout case.
Public methods related to `waitUntil` also seem to be waiting till specific duration.
e.g
```
public void waitUntilNoRegionsInTransition() throws IOException {
waitUntilNoRegionsInTransition(15 * 60000);
}
```
May be better to use `waitFor` directly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on a change in pull request #1286:
HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
URL: https://github.com/apache/hbase/pull/1286#discussion_r393391435
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/slowlog/TestSlowLogRecorder.java
##########
@@ -261,10 +287,12 @@ public void testOnlineSlowLogWithDefaultDisableConfig() throws Exception {
slowLogRecorder.addSlowLogPayload(rpcLogDetails);
}
- Uninterruptibles.sleepUninterruptibly(1, TimeUnit.SECONDS);
Review comment:
👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on issue #1286: HBASE-23977 : Resolve
flakes present in TestSlowLogRecorder
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
URL: https://github.com/apache/hbase/pull/1286#issuecomment-598783017
There's a utility method `waitUntil` that lets you wait for a condition to occur, or timeout. Check it's return value for the timeout case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani commented on issue #1286: HBASE-23977 : Resolve
flakes present in TestSlowLogRecorder
Posted by GitBox <gi...@apache.org>.
virajjasani commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
URL: https://github.com/apache/hbase/pull/1286#issuecomment-598854018
Spotbug in this build has nothing to do with this patch:
```
Return value of putIfAbsent is ignored, but node is reused in org.apache.hadoop.hbase.master.assignment.RegionStates.createRegionStateNode(RegionInfo)
```
Also, I think moving to spotbugs is a recent change, but why unit test is missing from the QA results? @ndimiduk are you aware of any very recent change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani commented on issue #1286: HBASE-23977 : Resolve
flakes present in TestSlowLogRecorder
Posted by GitBox <gi...@apache.org>.
virajjasani commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
URL: https://github.com/apache/hbase/pull/1286#issuecomment-599015485
Thanks Nick
Please review the patch @ndimiduk @saintstack
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani edited a comment on issue #1286: HBASE-23977 :
Resolve flakes present in TestSlowLogRecorder
Posted by GitBox <gi...@apache.org>.
virajjasani edited a comment on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
URL: https://github.com/apache/hbase/pull/1286#issuecomment-601020460
@ndimiduk @saintstack I just triggered a build and since I have run individual test 50-70 times in loop and they look good, let me commit this after QA results.
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on issue #1286: HBASE-23977 : Resolve
flakes present in TestSlowLogRecorder
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
URL: https://github.com/apache/hbase/pull/1286#issuecomment-598979839
@virajjasani
Sorry, yes, the utility method to which I refer is [`HBaseCommonTestingUtility#waitFor`](https://github.com/apache/hbase/blob/9cc7a711e616566ecedb8620a1c8b8a29c3d27b0/hbase-common/src/test/java/org/apache/hadoop/hbase/HBaseCommonTestingUtility.java#L247) and friends. See the underlying `Waiter` class for implementation details. Give that a spin.
Yes, there were recent changes in CI to support JDK11. The summary is posted on [this thread](https://lists.apache.org/thread.html/r8cb0c257be374b3f1b0d8caaa628eea874af77d2faae8c44918263d3%40%3Cdev.hbase.apache.org%3E). TL;DR, PR PreCommit now responds in 3 comments, not just one: "general checks", "JDK8", "JDK11". General checks has stuff like Findbugs/Spotbug and non-Java stuff. Look for unit test results the one with Java version 8, as I'm still working on the JDK11 harness.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on a change in pull request #1286:
HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
URL: https://github.com/apache/hbase/pull/1286#discussion_r393391150
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/slowlog/TestSlowLogRecorder.java
##########
@@ -140,12 +141,16 @@ public void testOnlieSlowLogConsumption() throws Exception {
Assert.assertNotEquals(-1, HBASE_TESTING_UTILITY.waitFor(3000,
() -> slowLogRecorder.getSlowLogPayloads(request).size() == 7));
- slowLogPayloads = slowLogRecorder.getSlowLogPayloads(request);
-
- Assert.assertEquals(slowLogPayloads.size(), 7);
- confirmPayloadParams(0, 7, slowLogPayloads);
- confirmPayloadParams(5, 2, slowLogPayloads);
- confirmPayloadParams(6, 1, slowLogPayloads);
+ Assert.assertNotEquals(-1, HBASE_TESTING_UTILITY.waitFor(3000,
+ () -> {
+ List<SlowLogPayload> slowLogPayloadsList = slowLogRecorder.getSlowLogPayloads(request);
+ Assert.assertEquals(slowLogPayloadsList.size(), 7);
+ boolean b1 = confirmPayloadParams(0, 7, slowLogPayloadsList);
Review comment:
I don't understand why these tests are executed within the timeout window. How does that make the tests more reliable?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani commented on issue #1286: HBASE-23977 : Resolve
flakes present in TestSlowLogRecorder
Posted by GitBox <gi...@apache.org>.
virajjasani commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
URL: https://github.com/apache/hbase/pull/1286#issuecomment-598782970
Yeah agree, let me quickly try it. Thanks @saintstack
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1286: HBASE-23977 :
Resolve flakes present in TestSlowLogRecorder
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
URL: https://github.com/apache/hbase/pull/1286#issuecomment-598877228
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 53s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 7m 15s | master passed |
| +1 :green_heart: | compile | 1m 23s | master passed |
| +1 :green_heart: | shadedjars | 5m 42s | branch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 44s | hbase-server in master failed. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 7m 16s | the patch passed |
| +1 :green_heart: | compile | 1m 17s | the patch passed |
| +1 :green_heart: | javac | 1m 17s | the patch passed |
| +1 :green_heart: | shadedjars | 6m 36s | patch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 1m 4s | hbase-server in the patch failed. |
||| _ Other Tests _ |
| -0 :warning: | unit | 158m 45s | hbase-server in the patch failed. |
| | | 193m 55s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1286 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 4fa528267fe3 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / b9e74e0b0a |
| Default Java | 2020-01-14 |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/2/testReport/ |
| Max. process+thread count | 4775 (vs. ulimit of 10000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/2/console |
| versions | git=2.17.1 maven=2018-06-17T18:33:14Z) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on a change in pull request #1286:
HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
URL: https://github.com/apache/hbase/pull/1286#discussion_r395330391
##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/slowlog/TestSlowLogRecorder.java
##########
@@ -140,12 +141,16 @@ public void testOnlieSlowLogConsumption() throws Exception {
Assert.assertNotEquals(-1, HBASE_TESTING_UTILITY.waitFor(3000,
() -> slowLogRecorder.getSlowLogPayloads(request).size() == 7));
- slowLogPayloads = slowLogRecorder.getSlowLogPayloads(request);
-
- Assert.assertEquals(slowLogPayloads.size(), 7);
- confirmPayloadParams(0, 7, slowLogPayloads);
- confirmPayloadParams(5, 2, slowLogPayloads);
- confirmPayloadParams(6, 1, slowLogPayloads);
+ Assert.assertNotEquals(-1, HBASE_TESTING_UTILITY.waitFor(3000,
+ () -> {
+ List<SlowLogPayload> slowLogPayloadsList = slowLogRecorder.getSlowLogPayloads(request);
+ Assert.assertEquals(slowLogPayloadsList.size(), 7);
+ boolean b1 = confirmPayloadParams(0, 7, slowLogPayloadsList);
Review comment:
Oh, I see. So you're actually using `waitFor` as a retry mechanism. That's not how I imagined using it, but so long as those inner asserts don't interfere with the retry, I guess that's fine.
What happens when the inner `Assert.assertEquals(slowLogPayloadsList.size(), 7);` throws? Does `waitFor` retry that, or does it simply fail? If the latter, the test is still flakey. I would loop until I have all the data and then perform the asserts at the end.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1286: HBASE-23977 :
Resolve flakes present in TestSlowLogRecorder
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1286: HBASE-23977 : Resolve flakes present in TestSlowLogRecorder
URL: https://github.com/apache/hbase/pull/1286#issuecomment-601047186
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 32s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 6m 34s | master passed |
| +1 :green_heart: | compile | 1m 5s | master passed |
| -1 :x: | shadedjars | 0m 11s | branch has 7 errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 44s | hbase-server in master failed. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 6m 22s | the patch passed |
| +1 :green_heart: | compile | 1m 14s | the patch passed |
| +1 :green_heart: | javac | 1m 14s | the patch passed |
| -1 :x: | shadedjars | 0m 10s | patch has 7 errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 41s | hbase-server in the patch failed. |
||| _ Other Tests _ |
| -0 :warning: | unit | 61m 13s | hbase-server in the patch failed. |
| | | 80m 45s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1286 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 20f88d468398 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 52a04e69c1 |
| Default Java | 2020-01-14 |
| shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/4/artifact/yetus-jdk11-hadoop3-check/output/branch-shadedjars.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt |
| shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/4/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/4/testReport/ |
| Max. process+thread count | 5882 (vs. ulimit of 10000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1286/4/console |
| versions | git=2.17.1 maven=2018-06-17T18:33:14Z) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services