You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by kunal642 <gi...@git.apache.org> on 2017/11/30 09:42:43 UTC
[GitHub] carbondata pull request #1598: [CARBONDATA-1841] Fix pre agg create
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/1598
[CARBONDATA-1841] Fix pre agg create
Checking if the load is available was giving wrong result due to wrong path which led data not being loaded into pre-agg table
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [X] Any interfaces changed?
- [X] Any backward compatibility impacted?
- [X] Document update required?
- [X] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kunal642/carbondata fix_pre_agg_create
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1598.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1598
----
commit 4530758d9f95f6a2c98ecff616b4a78652d8ec00
Author: kunal642 <ku...@gmail.com>
Date: 2017-11-30T09:38:02Z
data was not being loaded after pre-agg table creation
----
---
[GitHub] carbondata issue #1598: [CARBONDATA-1841] [PreAgg] Fix pre agg create after ...
Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/1598
LGTM
---
[GitHub] carbondata pull request #1598: [CARBONDATA-1841] [PreAgg] Fix pre agg create...
Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1598#discussion_r154063332
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/CreatePreAggregateTableCommand.scala ---
@@ -112,7 +112,8 @@ case class CreatePreAggregateTableCommand(
// load child table if parent table has existing segments
val dbName = CarbonEnv.getDatabaseName(parentTableIdentifier.database)(sparkSession)
val tableName = tableIdentifier.table
- val metastorePath = CarbonEnv.getMetadataPath(Some(dbName), tableName)(sparkSession)
+ val metastorePath = CarbonEnv.getMetadataPath(Some(dbName),
--- End diff --
Please add details comments for this method
---
[GitHub] carbondata issue #1598: [CARBONDATA-1841] [PreAgg] Fix pre agg create after ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1598
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1611/
---
[GitHub] carbondata issue #1598: [CARBONDATA-1841] Fix pre agg create
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1598
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1606/
---
[GitHub] carbondata issue #1598: [CARBONDATA-1841] [PreAgg] Fix pre agg create after ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1598
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1607/
---
[GitHub] carbondata pull request #1598: [CARBONDATA-1841][HOTFIX] [PreAgg] Fix pre ag...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/1598
---
[GitHub] carbondata issue #1598: [CARBONDATA-1841] [PreAgg] Fix pre agg create after ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1598
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2005/
---
[GitHub] carbondata issue #1598: [CARBONDATA-1841] Fix pre agg create
Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1598
retest this please
---