You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "Dave Thompson (Jira)" <ji...@apache.org> on 2023/06/15 17:02:00 UTC

[jira] [Closed] (DAFFODIL-2803) Warnings included in serialized DataProcessor

     [ https://issues.apache.org/jira/browse/DAFFODIL-2803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dave Thompson closed DAFFODIL-2803.
-----------------------------------

Verified the specified commit (commit 4c17bfed49942588d0ea10981e3eb131b3cc71e5) is included in the latest pull from the daffodil repository.

Verified, via review, changes identified in the commit comment were implemented. 

Verified the affected daffodil subproject sbt test suites executed successfully including the modified and added tests.

Verified the nightly test schemas compile and save successfully with no unexpected failures.

Verified the nightly test suite executes successfully with no unexpected failures.

> Warnings included in serialized DataProcessor
> ---------------------------------------------
>
>                 Key: DAFFODIL-2803
>                 URL: https://issues.apache.org/jira/browse/DAFFODIL-2803
>             Project: Daffodil
>          Issue Type: Bug
>          Components: Diagnostics
>    Affects Versions: 3.4.0
>            Reporter: Steve Lawrence
>            Priority: Major
>             Fix For: 3.5.0
>
>
> When a schema is compiled and serialized, any warnings that were created as part of the compilation are also serialized. Which means a reloaded DataProcessor includes those same warnings that were output during compilation.
> DAFFODIL-2267 modified the CLI so that it does not output any diagnostics on a reloaded DataProcessor, but API users could still output those diagnostics which is likely not what they want. Reloaded parsers really show have no diagnostics associated with them.
> Note that these reloaded warning diagnostic do not become part of the Parse/UnparseResult diagnostics. So even if API users output warnings on a reloaded DataProcessor, they at least won't see them for every parse.
> But to avoid the possibility of these excess warnings, we should modify the save parser function so that it removes all diagnostics from the DataProcessor when saved.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)