You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/03/14 15:32:15 UTC

[GitHub] [incubator-nuttx] v01d commented on pull request #3050: Added support for multiple syslog channels.

v01d commented on pull request #3050:
URL: https://github.com/apache/incubator-nuttx/pull/3050#issuecomment-798927500


   > Wouldn't it better to properly document the features in Kconfig help entries, or in the "proper" NuttX documentation?
   > Maybe I should document it in `nuttx/Documentation/components/drivers/special/syslog.rst`?
   
   Yes, please. This should actually be the norm when adding features/changing behavior.
   
   BTW, I'm not following how this interacts with Kconfig. Right now there are some options that indicate where to send syslog via a choice and other options. If this enables multiple outputs, shouldn't that be changed to a *multiple* choice? Kconfig options for syslog are also a bit messy, so any improvement in that sense would also be welcome.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org