You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ibatis.apache.org by cb...@apache.org on 2009/10/13 17:16:27 UTC
svn commit: r824801 - in /ibatis/java/ibatis-3/trunk/ibatis-3-core/src:
main/java/org/apache/ibatis/builder/xml/dynamic/ForEachSqlNode.java
test/java/org/apache/ibatis/builder/PostMapper.xml
Author: cbegin
Date: Tue Oct 13 15:16:26 2009
New Revision: 824801
URL: http://svn.apache.org/viewvc?rev=824801&view=rev
Log:
IBATIS-675 foreach tag throws exception if separator is not specified
Modified:
ibatis/java/ibatis-3/trunk/ibatis-3-core/src/main/java/org/apache/ibatis/builder/xml/dynamic/ForEachSqlNode.java
ibatis/java/ibatis-3/trunk/ibatis-3-core/src/test/java/org/apache/ibatis/builder/PostMapper.xml
Modified: ibatis/java/ibatis-3/trunk/ibatis-3-core/src/main/java/org/apache/ibatis/builder/xml/dynamic/ForEachSqlNode.java
URL: http://svn.apache.org/viewvc/ibatis/java/ibatis-3/trunk/ibatis-3-core/src/main/java/org/apache/ibatis/builder/xml/dynamic/ForEachSqlNode.java?rev=824801&r1=824800&r2=824801&view=diff
==============================================================================
--- ibatis/java/ibatis-3/trunk/ibatis-3-core/src/main/java/org/apache/ibatis/builder/xml/dynamic/ForEachSqlNode.java (original)
+++ ibatis/java/ibatis-3/trunk/ibatis-3-core/src/main/java/org/apache/ibatis/builder/xml/dynamic/ForEachSqlNode.java Tue Oct 13 15:16:26 2009
@@ -41,6 +41,8 @@
} else {
if (separator != null) {
context = new PrefixedContext(context, separator);
+ } else {
+ context = new PrefixedContext(context, "");
}
}
int uniqueNumber = context.getUniqueNumber();
Modified: ibatis/java/ibatis-3/trunk/ibatis-3-core/src/test/java/org/apache/ibatis/builder/PostMapper.xml
URL: http://svn.apache.org/viewvc/ibatis/java/ibatis-3/trunk/ibatis-3-core/src/test/java/org/apache/ibatis/builder/PostMapper.xml?rev=824801&r1=824800&r2=824801&view=diff
==============================================================================
--- ibatis/java/ibatis-3/trunk/ibatis-3-core/src/test/java/org/apache/ibatis/builder/PostMapper.xml (original)
+++ ibatis/java/ibatis-3/trunk/ibatis-3-core/src/test/java/org/apache/ibatis/builder/PostMapper.xml Tue Oct 13 15:16:26 2009
@@ -36,8 +36,8 @@
FROM POST P
WHERE ID in
<foreach item="item" index="index" collection="list"
- open="(" separator="," close=")">
- #{item}
+ open="(" close=")">
+ <if test="index != 0">,</if> #{item}
</foreach>
</select>