You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@netbeans.apache.org by Chris2011 <gi...@git.apache.org> on 2017/09/16 17:26:24 UTC
[GitHub] incubator-netbeans pull request #1: Feature/248233 doc split shortcut
GitHub user Chris2011 opened a pull request:
https://github.com/apache/incubator-netbeans/pull/1
Feature/248233 doc split shortcut
This PR will fix this original ticket: https://netbeans.org/bugzilla/show_bug.cgi?id=248233
* Created action for horizontally split and added shortcut
* Created action for vertically split and added shortcut
* Created action for clear split and added shortcut
* Refactored code a bit.
Regards
Chris
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Chris2011/incubator-netbeans feature/248233-doc-split-shortcut
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-netbeans/pull/1.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1
----
commit 67bdd60109474c543c010d3f818cfb36abb9c0c9
Author: Chris2011 <ch...@gmx.net>
Date: 2017-09-16T17:09:47Z
248233 - Added shortcut for vertical, horizontal and clear split.
commit 99b8e9df99c5b80dd09ff06df33562a027d5163c
Author: Chris2011 <ch...@gmx.net>
Date: 2017-09-16T17:17:59Z
Merge master into feature/248233-doc-split-shortcut
----
---
Re: [GitHub] incubator-netbeans pull request #1: Feature/248233 doc
split shortcut
Posted by Geertjan Wielenga <ge...@googlemail.com>.
Excellent! The first pull request -- and may there be many more.
Gj
On Sat, Sep 16, 2017 at 7:26 PM, Chris2011 <gi...@git.apache.org> wrote:
> GitHub user Chris2011 opened a pull request:
>
> https://github.com/apache/incubator-netbeans/pull/1
>
> Feature/248233 doc split shortcut
>
> This PR will fix this original ticket: https://netbeans.org/bugzilla/
> show_bug.cgi?id=248233
>
> * Created action for horizontally split and added shortcut
> * Created action for vertically split and added shortcut
> * Created action for clear split and added shortcut
> * Refactored code a bit.
>
>
> Regards
>
> Chris
>
> You can merge this pull request into a Git repository by running:
>
> $ git pull https://github.com/Chris2011/incubator-netbeans
> feature/248233-doc-split-shortcut
>
> Alternatively you can review and apply these changes as the patch at:
>
> https://github.com/apache/incubator-netbeans/pull/1.patch
>
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
> This closes #1
>
> ----
> commit 67bdd60109474c543c010d3f818cfb36abb9c0c9
> Author: Chris2011 <ch...@gmx.net>
> Date: 2017-09-16T17:09:47Z
>
> 248233 - Added shortcut for vertical, horizontal and clear split.
>
> commit 99b8e9df99c5b80dd09ff06df33562a027d5163c
> Author: Chris2011 <ch...@gmx.net>
> Date: 2017-09-16T17:17:59Z
>
> Merge master into feature/248233-doc-split-shortcut
>
> ----
>
>
> ---
>
[GitHub] incubator-netbeans pull request #1: Feature/248233 - Shortcuts for document ...
Posted by Chris2011 <gi...@git.apache.org>.
Github user Chris2011 closed the pull request at:
https://github.com/apache/incubator-netbeans/pull/1
---
Re: [GitHub] incubator-netbeans issue #1: Feature/248233 - Shortcuts
for document splitti...
Posted by Geertjan Wielenga <ge...@googlemail.com>.
Feel free to make pull requests, very welcome, but I think indeed before
they're accepted we need to do quite a bit of work on changing license
headers, as well as NOTICE and LICENSE files, that's the focus right now.
Gj
On Wed, Sep 20, 2017 at 12:00 PM, Chris2011 <gi...@git.apache.org> wrote:
> Github user Chris2011 commented on the issue:
>
> https://github.com/apache/incubator-netbeans/pull/1
>
> Yes, I knew that mail. But there is no official comment about that and
> no decision made yet.
>
>
> ---
>
[GitHub] incubator-netbeans issue #1: Feature/248233 - Shortcuts for document splitti...
Posted by Chris2011 <gi...@git.apache.org>.
Github user Chris2011 commented on the issue:
https://github.com/apache/incubator-netbeans/pull/1
Yes, I knew that mail. But there is no official comment about that and no decision made yet.
---
[GitHub] incubator-netbeans issue #1: Feature/248233 - Shortcuts for document splitti...
Posted by jlahoda <gi...@git.apache.org>.
Github user jlahoda commented on the issue:
https://github.com/apache/incubator-netbeans/pull/1
Chris, as was discussed elsewhere, the patches change line endings to Windows line endings (CRLF), and so look like deletion and addition of each line in the file (including the license headers, which I suppose you didn't want to change). Please fix this, ensuring the patch is using the just "LF" as line endings, and is only changing what should/needs to be changed. This is to keep the history clean, and to aid reviews. I'd also suggest to squash the commits and rebase, so that there's only one commit merged when this is being merged.
Thanks.
---
[GitHub] incubator-netbeans issue #1: Feature/248233 - Shortcuts for document splitti...
Posted by tusharvjoshi <gi...@git.apache.org>.
Github user tusharvjoshi commented on the issue:
https://github.com/apache/incubator-netbeans/pull/1
I verified the steps provided in JIRA ticket as follows:
1. Open any document what you want
2. Hit ctrl + shift + h to split the document horizontally
3. Hit ctrl + shift + v to split the document vetically
4. Hit ctrl + shift + c to clear split the document
5. Play around of hitting randomly the shortcuts
As I am working on macOS the shortcuts I had to use were comm + ctrl + shift + h, comm + ctrl + shift + v and comm + ctrl + shift + c
I confirm the working of these shortcuts as explained in the steps. Usually when we need keyboard shortcuts we also add Menu options for the actions, can we apply menu options for these actions also?
---
[GitHub] incubator-netbeans issue #1: Feature/248233 - Shortcuts for document splitti...
Posted by Chris2011 <gi...@git.apache.org>.
Github user Chris2011 commented on the issue:
https://github.com/apache/incubator-netbeans/pull/1
See this PR #3
---
[GitHub] incubator-netbeans issue #1: Feature/248233 - Shortcuts for document splitti...
Posted by Chris2011 <gi...@git.apache.org>.
Github user Chris2011 commented on the issue:
https://github.com/apache/incubator-netbeans/pull/1
Created a JIRA ticket too: https://issues.apache.org/jira/browse/NETBEANS-59
---
[GitHub] incubator-netbeans issue #1: Feature/248233 - Shortcuts for document splitti...
Posted by Chris2011 <gi...@git.apache.org>.
Github user Chris2011 commented on the issue:
https://github.com/apache/incubator-netbeans/pull/1
So what should I do exactly here? Changing the line endings back or what? It was not my intention to change that of course not. But I created 3 new files so all of these are really new files, which didn't exist before. Only to let you know that.
---
[GitHub] incubator-netbeans issue #1: Feature/248233 - Shortcuts for document splitti...
Posted by junichi11 <gi...@git.apache.org>.
Github user junichi11 commented on the issue:
https://github.com/apache/incubator-netbeans/pull/1
> So now I have to clone it again?
Perhaps, need not do it if the other file line endings are not `CRLF`. If you want to use this PR, you can do the following steps (I can be wrong):
1. Remove your remote branch once
2. Fix your line endings for your changes. then commit
3. To create just one commit, rebase (or git reset --soft and commit?)
4. Push your branch again
BTW, Did you read an email[1] from Jan? Probably, you should wait a while.
[1] https://lists.apache.org/thread.html/ed2718660a4c6a961be15d5d6c9febec9fc19b5ca5fb0d81eab34f0c@%3Cdev.netbeans.apache.org%3E
---
[GitHub] incubator-netbeans issue #1: Feature/248233 - Shortcuts for document splitti...
Posted by junichi11 <gi...@git.apache.org>.
Github user junichi11 commented on the issue:
https://github.com/apache/incubator-netbeans/pull/1
I've confirmed that your PR files have windows line endings.
Please try to check your line endings using the following plugin:
http://plugins.netbeans.org/plugin/36810/show-and-change-line-endings
The cause may be `core.autocrlf` configuration. Please try to check it:
```
git config -l
```
When you commit your changes, if line endings are not changed to `LF`, please try to change it to `false`.
e.g.
```
git config --global core.autocrlf false
```
Then, clone the repository again.
One Note:
If you create a new file in windows, its line ending is `CRLF` by default. So you have to change it.
Thanks.
---
[GitHub] incubator-netbeans issue #1: Feature/248233 - Shortcuts for document splitti...
Posted by Chris2011 <gi...@git.apache.org>.
Github user Chris2011 commented on the issue:
https://github.com/apache/incubator-netbeans/pull/1
@junichi11 thx for the info, yes I confirmed the line endings of CRLF too. So I changed the autocrlf from true to false. So now I have to clone it again? Maybe not possible to create a new feature branch and change the line endings?
So as I understand it right, I have to make a new PR with the changes, that I made again?
---