[GitHub] [hbase] ramkrish86 commented on pull request #1552: HBASE-24205 Create metric to know the number of reads that happens fr…

[GitBox <gi...@apache.org>]

ramkrish86 commented on pull request #1552:
URL: https://github.com/apache/hbase/pull/1552#issuecomment-635993029


   A new push which has the following changes
   -> Both gets and scans are covered in the same patch (we don do anything special for these just treat as same).
   -> Whether it is a scan or get - when we are at the StoreScanner loop where we check cell by cell till a row is done - we check if all the cells in that current loop till we return are from memstore or from file. Only then the corresponding metric is incremented. We no longer track the total gets that has landed on the StoreScanner. Say if out of 10 cells even if one cell is from memstore and remaining from file we don't account it with this metric. 
   -> The table level metric will now have a new aggregated metric
   
   >     "Namespace_default_table_TestTable_store_info0_metric_readRequestCountOnMemstore":1766,
   
   >    "Namespace_default_table_TestTable_store_info0_metric_readRequestCountOnFiles": 37828,
   
   This will be mapped per store for each table. 
   -> the patch also handles the cases where same family names can be across tables. Earlier that was not getting handled and now at the MetricStoreSource layer we add the region name and store name for the uniqueness.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org