You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2023/03/02 09:42:07 UTC
[GitHub] [ozone] adoroszlai commented on a diff in pull request #4286: HDDS-7934. NPE in RandomKeyGenerator's shutdown hook
adoroszlai commented on code in PR #4286:
URL: https://github.com/apache/ozone/pull/4286#discussion_r1122830765
##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/RandomKeyGenerator.java:
##########
@@ -484,8 +484,9 @@ private void printStats(PrintStream out) {
out.println("Number of Volumes created: " + numberOfVolumesCreated);
out.println("Number of Buckets created: " + numberOfBucketsCreated);
out.println("Number of Keys added: " + numberOfKeysAdded);
- out.println("Replication: " + replicationConfig.getReplication());
- out.println("Replication type: " + replicationConfig.getReplicationType());
+ if (replicationConfig != null) {
+ out.println("Replication: " + replicationConfig);
+ }
Review Comment:
I don't think the output of `ozone freon` is so important to guarantee any compatibility, especially the stats printed at exit.
##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/RandomKeyGenerator.java:
##########
@@ -484,8 +484,9 @@ private void printStats(PrintStream out) {
out.println("Number of Volumes created: " + numberOfVolumesCreated);
out.println("Number of Buckets created: " + numberOfBucketsCreated);
out.println("Number of Keys added: " + numberOfKeysAdded);
- out.println("Replication: " + replicationConfig.getReplication());
- out.println("Replication type: " + replicationConfig.getReplicationType());
+ if (replicationConfig != null) {
+ out.println("Replication: " + replicationConfig);
+ }
Review Comment:
I don't think the output of `ozone freon` is so important to guarantee any compatibility, especially for the stats printed at exit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org