You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by tgroh <gi...@git.apache.org> on 2017/04/21 15:51:10 UTC
[GitHub] beam pull request #2630: Improve GlobalWindow, IntervalWindow Coders
GitHub user tgroh opened a pull request:
https://github.com/apache/beam/pull/2630
Improve GlobalWindow, IntervalWindow Coders
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
Implement consistentWithEquals and verifyDeterministic on both of these
coders.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tgroh/beam window_coders_consistent_with_equals
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2630.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2630
----
commit 0343f09cb2a15bc092a8557ebbb6126a312b7d3d
Author: Thomas Groh <tg...@google.com>
Date: 2017-04-21T15:49:23Z
Improve GlobalWindow, IntervalWindow Coders
Implement consistentWithEquals and verifyDeterministic on both of these
coders.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] beam pull request #2630: Improve GlobalWindow, IntervalWindow Coders
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/beam/pull/2630
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---