You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/12 02:15:03 UTC

[GitHub] [apisix] spacewander commented on a change in pull request #2696: chore: sort the request headers output by the _M.uri and _M.old_uri function in t/lib/server.lua

spacewander commented on a change in pull request #2696:
URL: https://github.com/apache/apisix/pull/2696#discussion_r521774023



##########
File path: t/plugin/hmac-auth.t
##########
@@ -1246,16 +1246,16 @@ location /t {
 GET /t
 --- response_body
 uri: /uri
-host: 127.0.0.1
+content-length: 52
 content-type: application/x-www-form-urlencoded
-x-real-ip: 127.0.0.1
+host: 127.0.0.1
 user-agent: lua-resty-http/0.14 (Lua) ngx_lua/10017

Review comment:
       @Firstsawyou 
   Can we omit the `user-agent`? Since this field will change across different versions.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org