You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/03/19 09:03:59 UTC
[GitHub] [lucene-solr] uschindler commented on a change in pull request #2649: Remove '-' between base.version and version.suffix and change common-build to allow the new format
uschindler commented on a change in pull request #2649:
URL: https://github.com/apache/lucene-solr/pull/2649#discussion_r830460575
##########
File path: lucene/common-build.xml
##########
@@ -63,7 +63,7 @@
<fail message="If you pass -Dversion=... to set a release version, it must match "${version.base}", optionally followed by a suffix (e.g., "-SNAPSHOT").">
<condition>
- <not><matches pattern="^\Q${version.base}\E(|\-.*)$" casesensitive="true" string="${version}"/></not>
+ <not><matches pattern="^\Q${version.base}\E(|.*)$" casesensitive="true" string="${version}"/></not>
</condition>
Review comment:
At least there must be a `\b` (boundary) instead of the dash. This would match a version like 1.2.34 as valid for q.w.e base version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org