You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/07/27 04:20:25 UTC

[GitHub] [apisix-dashboard] LiteSun opened a new pull request #2004: chore: update auth plugin tip

LiteSun opened a new pull request #2004:
URL: https://github.com/apache/apisix-dashboard/pull/2004


   Please answer these questions before submitting a pull request, **or your PR will get closed**.
   
   **Why submit this pull request?**
   
   - [ ] Bugfix
   - [ ] New feature provided
   - [x] Improve performance
   - [ ] Backport patches
   
   **What changes will this PR take into?**
   
   chore: update auth plugin tip
   
   **Related issues**
   
   fix/resolve #0001
   
   **Checklist:**
   
   - [x] Did you explain what problem does this PR solve? Or what new features have been added?
   - [x] Have you added corresponding test cases?
   - [ ] Have you modified the corresponding document?
   - [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2004: chore: update auth plugin tip

Posted by GitBox <gi...@apache.org>.

netlify[bot] edited a comment on pull request #2004:
URL: https://github.com/apache/apisix-dashboard/pull/2004#issuecomment-887196390


   👷 Deploy Preview for *apisix-dashboard* processing.
   
   
   🔨 Explore the source changes: 5065356d2a5488c9b1fb0a35f24eedb80b21ff4e
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/6109de49d2bbc40008c49d36](https://app.netlify.com/sites/apisix-dashboard/deploys/6109de49d2bbc40008c49d36?utm_source=github&utm_campaign=bot_dl)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran commented on pull request #2004: chore: update auth plugin tip

Posted by GitBox <gi...@apache.org>.

liuxiran commented on pull request #2004:
URL: https://github.com/apache/apisix-dashboard/pull/2004#issuecomment-894583154


   hi @LiteSun please fix conflict file when you have time


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #2004: chore: update auth plugin tip

Posted by GitBox <gi...@apache.org>.

liuxiran commented on a change in pull request #2004:
URL: https://github.com/apache/apisix-dashboard/pull/2004#discussion_r680682714



##########
File path: web/cypress/integration/consumer/create_and_delete_consumer.spec.js
##########
@@ -57,6 +57,13 @@ context('Create and Delete Consumer', () => {
     cy.get(selector.description).type(data.description);
     cy.contains('Next').click();
 
+    cy.contains('Next').click();
+    cy.get(selector.notification).should(
+      'contain',
+      'Please enable at least one of the following authentication plugin:',

Review comment:
       when we do test, actually we know how many auth plugins and what they are, so we should assert the whole tip in order that we can make sure that the tip is complete




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2004: chore: update auth plugin tip

Posted by GitBox <gi...@apache.org>.

netlify[bot] edited a comment on pull request #2004:
URL: https://github.com/apache/apisix-dashboard/pull/2004#issuecomment-887196390


   ✔️ Deploy Preview for *apisix-dashboard* ready!
   
   
   🔨 Explore the source changes: 5065356d2a5488c9b1fb0a35f24eedb80b21ff4e
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/6109de49d2bbc40008c49d36](https://app.netlify.com/sites/apisix-dashboard/deploys/6109de49d2bbc40008c49d36?utm_source=github&utm_campaign=bot_dl)
   
   😎 Browse the preview: [https://deploy-preview-2004--apisix-dashboard.netlify.app/](https://deploy-preview-2004--apisix-dashboard.netlify.app/?utm_source=github&utm_campaign=bot_dp)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #2004: chore: update auth plugin tip

Posted by GitBox <gi...@apache.org>.

juzhiyuan merged pull request #2004:
URL: https://github.com/apache/apisix-dashboard/pull/2004


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #2004: chore: update auth plugin tip

Posted by GitBox <gi...@apache.org>.

juzhiyuan commented on pull request #2004:
URL: https://github.com/apache/apisix-dashboard/pull/2004#issuecomment-889151079


   @LiteSun Please update the test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2004: chore: update auth plugin tip

Posted by GitBox <gi...@apache.org>.

netlify[bot] edited a comment on pull request #2004:
URL: https://github.com/apache/apisix-dashboard/pull/2004#issuecomment-887196390


   ✔️ Deploy Preview for *apisix-dashboard* ready!
   
   
   🔨 Explore the source changes: 0bf6132859ddd71060e2577de2aaf60c55cc4302
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/61107545188f0b0007d66032](https://app.netlify.com/sites/apisix-dashboard/deploys/61107545188f0b0007d66032?utm_source=github&utm_campaign=bot_dl)
   
   😎 Browse the preview: [https://deploy-preview-2004--apisix-dashboard.netlify.app/](https://deploy-preview-2004--apisix-dashboard.netlify.app/?utm_source=github&utm_campaign=bot_dp)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2004: chore: update auth plugin tip

Posted by GitBox <gi...@apache.org>.

netlify[bot] edited a comment on pull request #2004:
URL: https://github.com/apache/apisix-dashboard/pull/2004#issuecomment-887196390


   👷 Deploy Preview for *apisix-dashboard* processing.
   
   
   🔨 Explore the source changes: b5ca00943d16215d5f0bcaed12b1d49890b59981
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/60ffb8a82f817f000853a8b7](https://app.netlify.com/sites/apisix-dashboard/deploys/60ffb8a82f817f000853a8b7?utm_source=github&utm_campaign=bot_dl)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #2004: chore: update auth plugin tip

Posted by GitBox <gi...@apache.org>.

codecov-commenter commented on pull request #2004:
URL: https://github.com/apache/apisix-dashboard/pull/2004#issuecomment-889576947


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2004?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2004](https://codecov.io/gh/apache/apisix-dashboard/pull/2004?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b5ca009) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/82575987ebc18b46676a397732c2c4c09dd37191?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8257598) will **decrease** coverage by `3.83%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2004/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2004?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #2004      +/-   ##
   ==========================================
   - Coverage   67.95%   64.12%   -3.84%     
   ==========================================
     Files         182      122      -60     
     Lines        6971     3158    -3813     
     Branches      753      753              
   ==========================================
   - Hits         4737     2025    -2712     
   + Misses       1948     1133     -815     
   + Partials      286        0     -286     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `?` | |
   | backend-unit-test | `?` | |
   | frontend-e2e-test | `64.12% <100.00%> (+0.10%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2004?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [web/src/components/Plugin/data.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2004/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9kYXRhLnRzeA==) | `100.00% <ø> (ø)` | |
   | [web/src/pages/Consumer/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2004/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9DcmVhdGUudHN4) | `82.00% <100.00%> (+5.91%)` | :arrow_up: |
   | [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2004/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | | |
   | [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2004/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | | |
   | [api/internal/handler/handler.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2004/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGFuZGxlci5nbw==) | | |
   | [api/internal/core/store/store\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2004/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVfbW9jay5nbw==) | | |
   | [api/internal/handler/upstream/upstream.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2004/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdXBzdHJlYW0vdXBzdHJlYW0uZ28=) | | |
   | [api/internal/utils/json\_patch.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2004/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2pzb25fcGF0Y2guZ28=) | | |
   | [api/internal/log/zap.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2004/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2xvZy96YXAuZ28=) | | |
   | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2004/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | | |
   | ... and [52 more](https://codecov.io/gh/apache/apisix-dashboard/pull/2004/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2004?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2004?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [8257598...b5ca009](https://codecov.io/gh/apache/apisix-dashboard/pull/2004?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2004: chore: update auth plugin tip

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #2004:
URL: https://github.com/apache/apisix-dashboard/pull/2004#issuecomment-889576947


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2004?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2004](https://codecov.io/gh/apache/apisix-dashboard/pull/2004?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0bf6132) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/5a581d3f0fa0f74a634af93f14fc779c16454938?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5a581d3) will **increase** coverage by `0.18%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2004/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2004?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #2004      +/-   ##
   ==========================================
   + Coverage   65.69%   65.88%   +0.18%     
   ==========================================
     Files         121      121              
     Lines        3204     3210       +6     
     Branches      778      778              
   ==========================================
   + Hits         2105     2115      +10     
   + Misses       1099     1095       -4     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | frontend-e2e-test | `65.88% <100.00%> (+0.18%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2004?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [web/src/components/Plugin/data.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2004/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9kYXRhLnRzeA==) | `100.00% <ø> (ø)` | |
   | [web/src/pages/Consumer/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2004/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9DcmVhdGUudHN4) | `82.69% <100.00%> (+6.60%)` | :arrow_up: |
   | [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2004/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `72.13% <0.00%> (+3.27%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2004?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2004?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5a581d3...0bf6132](https://codecov.io/gh/apache/apisix-dashboard/pull/2004?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2004: chore: update auth plugin tip

Posted by GitBox <gi...@apache.org>.

netlify[bot] edited a comment on pull request #2004:
URL: https://github.com/apache/apisix-dashboard/pull/2004#issuecomment-887196390


   👷 Deploy Preview for *apisix-dashboard* processing.
   
   
   🔨 Explore the source changes: 0bf6132859ddd71060e2577de2aaf60c55cc4302
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/61107545188f0b0007d66032](https://app.netlify.com/sites/apisix-dashboard/deploys/61107545188f0b0007d66032?utm_source=github&utm_campaign=bot_dl)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #2004: chore: update auth plugin tip

Posted by GitBox <gi...@apache.org>.

netlify[bot] commented on pull request #2004:
URL: https://github.com/apache/apisix-dashboard/pull/2004#issuecomment-887196390


   👷 Deploy Preview for *apisix-dashboard* processing.
   
   
   🔨 Explore the source changes: c9c91588783ce71d063946d2e5095b21c3118318
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/60ff8982ef78a5000758164f](https://app.netlify.com/sites/apisix-dashboard/deploys/60ff8982ef78a5000758164f?utm_source=github&utm_campaign=bot_dl)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2004: chore: update auth plugin tip

Posted by GitBox <gi...@apache.org>.

netlify[bot] edited a comment on pull request #2004:
URL: https://github.com/apache/apisix-dashboard/pull/2004#issuecomment-887196390


   ✔️ Deploy Preview for *apisix-dashboard* ready!
   
   
   🔨 Explore the source changes: c9c91588783ce71d063946d2e5095b21c3118318
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/60ff8982ef78a5000758164f](https://app.netlify.com/sites/apisix-dashboard/deploys/60ff8982ef78a5000758164f?utm_source=github&utm_campaign=bot_dl)
   
   😎 Browse the preview: [https://deploy-preview-2004--apisix-dashboard.netlify.app/](https://deploy-preview-2004--apisix-dashboard.netlify.app/?utm_source=github&utm_campaign=bot_dp)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2004: chore: update auth plugin tip

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #2004:
URL: https://github.com/apache/apisix-dashboard/pull/2004#issuecomment-889576947


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2004?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2004](https://codecov.io/gh/apache/apisix-dashboard/pull/2004?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5065356) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/82575987ebc18b46676a397732c2c4c09dd37191?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8257598) will **decrease** coverage by `3.78%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2004/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2004?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #2004      +/-   ##
   ==========================================
   - Coverage   67.95%   64.16%   -3.79%     
   ==========================================
     Files         182      121      -61     
     Lines        6971     3162    -3809     
     Branches      753      753              
   ==========================================
   - Hits         4737     2029    -2708     
   + Misses       1948     1133     -815     
   + Partials      286        0     -286     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `?` | |
   | backend-unit-test | `?` | |
   | frontend-e2e-test | `64.16% <100.00%> (+0.15%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2004?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [web/src/components/Plugin/data.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2004/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9kYXRhLnRzeA==) | `100.00% <ø> (ø)` | |
   | [web/src/pages/Consumer/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2004/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9DcmVhdGUudHN4) | `82.69% <100.00%> (+6.60%)` | :arrow_up: |
   | [web/src/components/RightContent/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2004/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1JpZ2h0Q29udGVudC9pbmRleC50c3g=) | `83.33% <0.00%> (-3.34%)` | :arrow_down: |
   | [web/src/components/Plugin/UI/plugin.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2004/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9wbHVnaW4udHN4) | `82.60% <0.00%> (ø)` | |
   | [web/src/components/Plugin/UI/limit-req.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2004/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9saW1pdC1yZXEudHN4) | `100.00% <0.00%> (ø)` | |
   | [web/src/components/Upstream/components/Type.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2004/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvVHlwZS50c3g=) | `100.00% <0.00%> (ø)` | |
   | [api/cmd/start.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2004/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9zdGFydC5nbw==) | | |
   | [api/internal/handler/data\_loader/route\_export.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2004/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfZXhwb3J0Lmdv) | | |
   | [api/internal/handler/schema/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2004/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3BsdWdpbi5nbw==) | | |
   | [api/cmd/remove.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2004/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9yZW1vdmUuZ28=) | | |
   | ... and [58 more](https://codecov.io/gh/apache/apisix-dashboard/pull/2004/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2004?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2004?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [8257598...5065356](https://codecov.io/gh/apache/apisix-dashboard/pull/2004?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2004: chore: update auth plugin tip

Posted by GitBox <gi...@apache.org>.

netlify[bot] edited a comment on pull request #2004:
URL: https://github.com/apache/apisix-dashboard/pull/2004#issuecomment-887196390


   ✔️ Deploy Preview for *apisix-dashboard* ready!
   
   
   🔨 Explore the source changes: b5ca00943d16215d5f0bcaed12b1d49890b59981
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/60ffb8a82f817f000853a8b7](https://app.netlify.com/sites/apisix-dashboard/deploys/60ffb8a82f817f000853a8b7?utm_source=github&utm_campaign=bot_dl)
   
   😎 Browse the preview: [https://deploy-preview-2004--apisix-dashboard.netlify.app](https://deploy-preview-2004--apisix-dashboard.netlify.app?utm_source=github&utm_campaign=bot_dp)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org