You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by Ethanlm <gi...@git.apache.org> on 2017/07/13 20:57:59 UTC
[GitHub] storm pull request #2209: [STORM-2622] Add owner resource summary on storm U...
GitHub user Ethanlm opened a pull request:
https://github.com/apache/storm/pull/2209
[STORM-2622] Add owner resource summary on storm UI
At Yahoo, we have a "Owner Summary" section in Storm UI to display the resources a user is using and guaranteed. This work is done by @abellina. I am porting the code back to apache storm.
https://issues.apache.org/jira/browse/STORM-2622
Fixed some storm-cassandra checkstyle isses to pass the build.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Ethanlm/storm STORM-2622
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2209.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2209
----
commit 440356cd24fb1e77268abe6afc0a32111754ce7b
Author: Ethan Li <et...@gmail.com>
Date: 2017-07-12T18:03:15Z
[STORM-2622] Add owner resource summary
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2209: [STORM-2622] Add owner resource summary on storm UI
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the issue:
https://github.com/apache/storm/pull/2209
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2209: [STORM-2622] Add owner resource summary on storm UI
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2209
@Ethanlm
Could you share the screenshot of the changed page? That helps to see the benefit of the patch easily.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2209: [STORM-2622] Add owner resource summary on storm U...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2209
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2209: [STORM-2622] Add owner resource summary on storm U...
Posted by Ethanlm <gi...@git.apache.org>.
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2209#discussion_r127463843
--- Diff: storm-server/src/main/java/org/apache/storm/LocalCluster.java ---
@@ -1095,6 +1096,12 @@ public TopologyHistoryInfo getTopologyHistory(String user) throws AuthorizationE
return ret;
}
}
+
+ @Override
+ public List<OwnerResourceSummary> getOwnerResourceSummaries(String owner) throws AuthorizationException, TException {
+ // TODO Auto-generated method stub
+ throw new RuntimeException("NOT IMPLMENETED YET");
--- End diff --
Thanks. Fixed it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2209: [STORM-2622] Add owner resource summary on storm UI
Posted by Ethanlm <gi...@git.apache.org>.
Github user Ethanlm commented on the issue:
https://github.com/apache/storm/pull/2209
Added some unit tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2209: [STORM-2622] Add owner resource summary on storm U...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2209#discussion_r127377733
--- Diff: storm-server/src/main/java/org/apache/storm/LocalCluster.java ---
@@ -1095,6 +1096,12 @@ public TopologyHistoryInfo getTopologyHistory(String user) throws AuthorizationE
return ret;
}
}
+
+ @Override
+ public List<OwnerResourceSummary> getOwnerResourceSummaries(String owner) throws AuthorizationException, TException {
+ // TODO Auto-generated method stub
+ throw new RuntimeException("NOT IMPLMENETED YET");
--- End diff --
nit: `NOT IMPLEMENTED YET`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2209: [STORM-2622] Add owner resource summary on storm UI
Posted by vesense <gi...@git.apache.org>.
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2209
Looks great. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2209: [STORM-2622] Add owner resource summary on storm UI
Posted by Ethanlm <gi...@git.apache.org>.
Github user Ethanlm commented on the issue:
https://github.com/apache/storm/pull/2209
<img width="1281" alt="screen shot 2017-07-14 at 9 09 08 am" src="https://user-images.githubusercontent.com/14900612/28215602-313cb8e6-6874-11e7-8055-55d6c0b491c3.png">
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---