[jira] [Commented] (FLINK-16221) Execution::transitionState() should log an error when error parameter is not null

["Gary Yao (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-16221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17044339#comment-17044339 ] 

Gary Yao commented on FLINK-16221:
----------------------------------

I think the reason why we do not log this on error level currently is that for the cluster this is not considered an error. If user code throws an exception, it is not critical for the cluster's health.

cc: [~trohrmann]

> Execution::transitionState() should log an error when error parameter is not null 
> ----------------------------------------------------------------------------------
>
>                 Key: FLINK-16221
>                 URL: https://issues.apache.org/jira/browse/FLINK-16221
>             Project: Flink
>          Issue Type: Improvement
>          Components: Runtime / Coordination
>    Affects Versions: 1.9.2, 1.10.0
>            Reporter: yazgoo
>            Priority: Major
>         Attachments: info_to_error.patch
>
>
> When execution state transitions with an error, an INFO is logged n Execution::transitionState().
>  I think an ERROR should be logged.
>  This is especially usefull when states transitions to failing, to be able to retrieve the error causing the failure.
>  So:
> |LOG.*info*("{} ({}) switched from {} to {}.", getVertex().getTaskNameWithSubtaskIndex(), getAttemptId(), currentState, targetState, error);|
> should become
> |LOG.*error*("{} ({}) switched from {} to {}.", getVertex().getTaskNameWithSubtaskIndex(), getAttemptId(), currentState, targetState, error);|



--
This message was sent by Atlassian Jira
(v8.3.4#803005)