You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Aravindan Vijayan <av...@hortonworks.com> on 2017/12/01 00:07:21 UTC
Re: Review Request 64221: AMBARI-22567 : Integrate Spark lifecycle
management into AMS AD Manager.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64221/
-----------------------------------------------------------
(Updated Dec. 1, 2017, 12:07 a.m.)
Review request for Ambari, Jayush Luniya and Sid Wagle.
Changes
-------
Fixed review comments.
Bugs: AMBARI-22567
https://issues.apache.org/jira/browse/AMBARI-22567
Repository: ambari
Description
-------
Package spark tar ball along with AD Manager jar.
Implement START/STOP of embedded spark master + worker as a step in AD Manager start/stop.
Build ambari-metrics-admanager RPM
Verify ability to configure and deploy AD Manager using Ambari.
Diffs (updated)
-----
ambari-metrics/ambari-metrics-anomaly-detection-service/conf/unix/ambari-metrics-admanager PRE-CREATION
ambari-metrics/ambari-metrics-anomaly-detection-service/conf/unix/ambari-metrics-admanager.sh f1a1ae3
ambari-metrics/ambari-metrics-anomaly-detection-service/conf/unix/config.yaml PRE-CREATION
ambari-metrics/ambari-metrics-anomaly-detection-service/pom.xml c6927dd
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/assemblies/empty.xml PRE-CREATION
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/resources/config.yml 7de06b4
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/app/AnomalyDetectionAppConfig.scala f9ed4b2
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/common/Range.scala 003c18f
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/common/Season.scala f875e3b
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/common/SeasonType.scala 067972c
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/common/TimeRange.scala 50df658
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/configuration/MetricDefinitionServiceConfiguration.scala b560713
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/configuration/SparkConfiguration.scala PRE-CREATION
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/db/PhoenixAnomalyStoreAccessor.scala 147d1f7
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/model/PointInTimeAnomalyInstance.scala PRE-CREATION
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/model/Range.scala PRE-CREATION
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/model/Season.scala PRE-CREATION
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/model/SeasonType.scala PRE-CREATION
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/model/TimeRange.scala PRE-CREATION
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/model/TrendAnomalyInstance.scala PRE-CREATION
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/subsystem/pointintime/PointInTimeAnomalyInstance.scala 56ca2c1
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/subsystem/trend/TrendAnomalyInstance.scala 7392d59
ambari-metrics/ambari-metrics-anomaly-detection-service/src/test/resources/config.yaml PRE-CREATION
ambari-metrics/ambari-metrics-anomaly-detection-service/src/test/scala/org/apache/ambari/metrics/adservice/app/AnomalyDetectionAppConfigTest.scala 989ba21
ambari-metrics/ambari-metrics-anomaly-detection-service/src/test/scala/org/apache/ambari/metrics/adservice/app/DefaultADResourceSpecTest.scala e38ea40
ambari-metrics/ambari-metrics-anomaly-detection-service/src/test/scala/org/apache/ambari/metrics/adservice/common/RangeTest.scala b610b97
ambari-metrics/ambari-metrics-anomaly-detection-service/src/test/scala/org/apache/ambari/metrics/adservice/common/SeasonTest.scala a823c73
ambari-metrics/ambari-metrics-anomaly-detection-service/src/test/scala/org/apache/ambari/metrics/adservice/model/RangeTest.scala PRE-CREATION
ambari-metrics/ambari-metrics-anomaly-detection-service/src/test/scala/org/apache/ambari/metrics/adservice/model/SeasonTest.scala PRE-CREATION
ambari-metrics/ambari-metrics-assembly/pom.xml d9875ce
ambari-metrics/ambari-metrics-assembly/src/main/assembly/anomaly-detection.xml PRE-CREATION
ambari-metrics/ambari-metrics-assembly/src/main/package/rpm/anomaly-detection/postinstall.sh PRE-CREATION
ambari-metrics/pom.xml 4848084
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-admanager-config.xml 2c6bbf7
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-admanager-env.xml a79796b
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-admanager-log4j.xml b1f821e
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-admanager-spark-env.xml PRE-CREATION
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml a80340c
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py b22a870
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams_admanager.py 96c4454
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py b7004b8
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status_params.py c01b368
Diff: https://reviews.apache.org/r/64221/diff/3/
Changes: https://reviews.apache.org/r/64221/diff/2-3/
Testing
-------
Manually tested.
Thanks,
Aravindan Vijayan