You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@orc.apache.org by do...@apache.org on 2021/09/28 15:09:43 UTC
[orc] branch branch-1.7 updated: ORC-1009: [C++] Missing string
include causes build failure with MSVC++ (#919)
This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch branch-1.7
in repository https://gitbox.apache.org/repos/asf/orc.git
The following commit(s) were added to refs/heads/branch-1.7 by this push:
new d8894aa ORC-1009: [C++] Missing string include causes build failure with MSVC++ (#919)
d8894aa is described below
commit d8894aade2a9afc0d79baa8309bf7ca788b34d61
Author: noirello <no...@gmail.com>
AuthorDate: Tue Sep 28 17:08:05 2021 +0200
ORC-1009: [C++] Missing string include causes build failure with MSVC++ (#919)
### What changes were proposed in this pull request?
Include string in ExpressionTree.hh.
### Why are the changes needed?
Without it the library cannot be built on Windows with newer msvc++ compiler (version 19.29).
### How was this patch tested?
Manually, successfully building the library on Windows on a local machine.
(cherry picked from commit 3c9623e11e3be45cdde4435870db3376a3e7a864)
Signed-off-by: Dongjoon Hyun <do...@apache.org>
---
c++/src/sargs/ExpressionTree.hh | 1 +
1 file changed, 1 insertion(+)
diff --git a/c++/src/sargs/ExpressionTree.hh b/c++/src/sargs/ExpressionTree.hh
index 7625fde..bb3d16e 100644
--- a/c++/src/sargs/ExpressionTree.hh
+++ b/c++/src/sargs/ExpressionTree.hh
@@ -23,6 +23,7 @@
#include <limits>
#include <memory>
+#include <string>
#include <vector>
static const size_t UNUSED_LEAF = std::numeric_limits<size_t>::max();