[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3742: [Spark load][Be 1/1] Be handle push task

[GitBox <gi...@apache.org>]

kangkaisen commented on a change in pull request #3742:
URL: https://github.com/apache/incubator-doris/pull/3742#discussion_r433307314



##########
File path: be/src/olap/push_handler.h
##########
@@ -209,6 +216,44 @@ class LzoBinaryReader: public IBinaryReader {
     size_t _next_row_start;
 };
 
+class PushBrokerReader {
+public:
+    PushBrokerReader() 
+        : _ready(false),
+          _eof(false) {}
+    ~PushBrokerReader() {}
+
+    OLAPStatus init(const Schema* schema,
+                    const TBrokerScanRange& t_scan_range,
+                    const TDescriptorTable& t_desc_tbl);
+    OLAPStatus next(ContiguousRow* row);
+    void print_profile();
+
+    OLAPStatus finalize() {

Review comment:
       I think for reader, `close` maybe better than `finalize`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org