[GitHub] [arrow] waynexia commented on a change in pull request #8862: ARROW-10836: [Rust] Extend take kernel to FixedSizeListArray

[GitBox <gi...@apache.org>]

waynexia commented on a change in pull request #8862:
URL: https://github.com/apache/arrow/pull/8862#discussion_r540881973



##########
File path: rust/arrow/src/compute/kernels/take.rs
##########
@@ -1109,6 +1187,62 @@ mod tests {
         test_take_list_with_nulls!(i64, LargeList, LargeListArray);
     }
 
+    #[test]
+    fn test_take_fixed_size_list() {
+        do_take_fixed_size_list_test::<Int32Type>(
+            3,
+            vec![
+                Some(vec![Some(0), Some(1), Some(2)]),
+                Some(vec![Some(3), Some(4), Some(5)]),
+                Some(vec![Some(6), Some(7), Some(8)]),
+            ],
+            vec![2, 1, 0],

Review comment:
       Really appreciate your review!
   
   The third case used null indices (`2` in `[3, 2, 1, 2, 0]`) if you mean to null value inside a list.
   
   BTW I also changed the first case to include some nulls in sub-array in the following commit.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org