You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Otis Gospodnetic (JIRA)" <ji...@apache.org> on 2011/03/03 23:04:36 UTC
[jira] Created: (HBASE-3597) ageOfLastAppliedOp should update after
cluster replication failures
ageOfLastAppliedOp should update after cluster replication failures
-------------------------------------------------------------------
Key: HBASE-3597
URL: https://issues.apache.org/jira/browse/HBASE-3597
Project: HBase
Issue Type: Bug
Components: replication
Affects Versions: 0.90.1
Reporter: Otis Gospodnetic
Fix For: 0.90.2
The value of ageOfLastAppliedOp in JMX doesn't update after replication starts failing, and it should. See: http://search-hadoop.com/m/jFPgF1HfnLc
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3597) ageOfLastAppliedOp should update
after cluster replication failures
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028585#comment-13028585 ]
stack commented on HBASE-3597:
------------------------------
+1
> ageOfLastAppliedOp should update after cluster replication failures
> -------------------------------------------------------------------
>
> Key: HBASE-3597
> URL: https://issues.apache.org/jira/browse/HBASE-3597
> Project: HBase
> Issue Type: Bug
> Components: replication
> Affects Versions: 0.90.1
> Reporter: Otis Gospodnetic
> Assignee: Jean-Daniel Cryans
> Fix For: 0.90.3
>
> Attachments: HBASE-3597.patch
>
>
> The value of ageOfLastAppliedOp in JMX doesn't update after replication starts failing, and it should. See: http://search-hadoop.com/m/jFPgF1HfnLc
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-3597) ageOfLastAppliedOp should update
after cluster replication failures
Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Daniel Cryans updated HBASE-3597:
--------------------------------------
Fix Version/s: (was: 0.90.2)
0.90.3
I guess I would be the one working on this and I won't have time for 0.90.2, so punting.
> ageOfLastAppliedOp should update after cluster replication failures
> -------------------------------------------------------------------
>
> Key: HBASE-3597
> URL: https://issues.apache.org/jira/browse/HBASE-3597
> Project: HBase
> Issue Type: Bug
> Components: replication
> Affects Versions: 0.90.1
> Reporter: Otis Gospodnetic
> Fix For: 0.90.3
>
>
> The value of ageOfLastAppliedOp in JMX doesn't update after replication starts failing, and it should. See: http://search-hadoop.com/m/jFPgF1HfnLc
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3597) ageOfLastAppliedOp should update
after cluster replication failures
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13030217#comment-13030217 ]
Hudson commented on HBASE-3597:
-------------------------------
Integrated in HBase-TRUNK #1909 (See [https://builds.apache.org/hudson/job/HBase-TRUNK/1909/])
> ageOfLastAppliedOp should update after cluster replication failures
> -------------------------------------------------------------------
>
> Key: HBASE-3597
> URL: https://issues.apache.org/jira/browse/HBASE-3597
> Project: HBase
> Issue Type: Bug
> Components: replication
> Affects Versions: 0.90.1
> Reporter: Otis Gospodnetic
> Assignee: Jean-Daniel Cryans
> Fix For: 0.90.3
>
> Attachments: HBASE-3597.patch
>
>
> The value of ageOfLastAppliedOp in JMX doesn't update after replication starts failing, and it should. See: http://search-hadoop.com/m/jFPgF1HfnLc
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-3597) ageOfLastAppliedOp should update
after cluster replication failures
Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Daniel Cryans reassigned HBASE-3597:
-----------------------------------------
Assignee: Jean-Daniel Cryans
> ageOfLastAppliedOp should update after cluster replication failures
> -------------------------------------------------------------------
>
> Key: HBASE-3597
> URL: https://issues.apache.org/jira/browse/HBASE-3597
> Project: HBase
> Issue Type: Bug
> Components: replication
> Affects Versions: 0.90.1
> Reporter: Otis Gospodnetic
> Assignee: Jean-Daniel Cryans
> Fix For: 0.90.3
>
> Attachments: HBASE-3597.patch
>
>
> The value of ageOfLastAppliedOp in JMX doesn't update after replication starts failing, and it should. See: http://search-hadoop.com/m/jFPgF1HfnLc
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-3597) ageOfLastAppliedOp should update
after cluster replication failures
Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Daniel Cryans updated HBASE-3597:
--------------------------------------
Attachment: HBASE-3597.patch
Patch that I think will fix the issue, it adds a way to refresh the age of the last shipped edit in case replication fails.
> ageOfLastAppliedOp should update after cluster replication failures
> -------------------------------------------------------------------
>
> Key: HBASE-3597
> URL: https://issues.apache.org/jira/browse/HBASE-3597
> Project: HBase
> Issue Type: Bug
> Components: replication
> Affects Versions: 0.90.1
> Reporter: Otis Gospodnetic
> Fix For: 0.90.3
>
> Attachments: HBASE-3597.patch
>
>
> The value of ageOfLastAppliedOp in JMX doesn't update after replication starts failing, and it should. See: http://search-hadoop.com/m/jFPgF1HfnLc
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HBASE-3597) ageOfLastAppliedOp should update
after cluster replication failures
Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13002276#comment-13002276 ]
Jean-Daniel Cryans commented on HBASE-3597:
-------------------------------------------
We're not big users of that field, but AFAIK "replication" is the right one as it's the name of the package.
> ageOfLastAppliedOp should update after cluster replication failures
> -------------------------------------------------------------------
>
> Key: HBASE-3597
> URL: https://issues.apache.org/jira/browse/HBASE-3597
> Project: HBase
> Issue Type: Bug
> Components: replication
> Affects Versions: 0.90.1
> Reporter: Otis Gospodnetic
> Fix For: 0.90.2
>
>
> The value of ageOfLastAppliedOp in JMX doesn't update after replication starts failing, and it should. See: http://search-hadoop.com/m/jFPgF1HfnLc
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HBASE-3597) ageOfLastAppliedOp should update
after cluster replication failures
Posted by "Otis Gospodnetic (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13002273#comment-13002273 ]
Otis Gospodnetic commented on HBASE-3597:
-----------------------------------------
btw. this is filed under "replication" component because there is no "cluster replication" component. Maybe it should be added?
> ageOfLastAppliedOp should update after cluster replication failures
> -------------------------------------------------------------------
>
> Key: HBASE-3597
> URL: https://issues.apache.org/jira/browse/HBASE-3597
> Project: HBase
> Issue Type: Bug
> Components: replication
> Affects Versions: 0.90.1
> Reporter: Otis Gospodnetic
> Fix For: 0.90.2
>
>
> The value of ageOfLastAppliedOp in JMX doesn't update after replication starts failing, and it should. See: http://search-hadoop.com/m/jFPgF1HfnLc
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3597) ageOfLastAppliedOp should update
after cluster replication failures
Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028452#comment-13028452 ]
Jean-Daniel Cryans commented on HBASE-3597:
-------------------------------------------
That would be called on average once or twice per second on a normal cluster, I'm pretty sure DefaultEnvironmentEdge is a few order of magnitudes more expensive than what those metrics are doing.
> ageOfLastAppliedOp should update after cluster replication failures
> -------------------------------------------------------------------
>
> Key: HBASE-3597
> URL: https://issues.apache.org/jira/browse/HBASE-3597
> Project: HBase
> Issue Type: Bug
> Components: replication
> Affects Versions: 0.90.1
> Reporter: Otis Gospodnetic
> Assignee: Jean-Daniel Cryans
> Fix For: 0.90.3
>
> Attachments: HBASE-3597.patch
>
>
> The value of ageOfLastAppliedOp in JMX doesn't update after replication starts failing, and it should. See: http://search-hadoop.com/m/jFPgF1HfnLc
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-3597) ageOfLastAppliedOp should update
after cluster replication failures
Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Daniel Cryans resolved HBASE-3597.
---------------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Committed to branch and trunk, talked to Stack offline and he thought he saw that it was calling currentTimeMillis for every edit but it's only for the last one we ship so he was ok with it.
> ageOfLastAppliedOp should update after cluster replication failures
> -------------------------------------------------------------------
>
> Key: HBASE-3597
> URL: https://issues.apache.org/jira/browse/HBASE-3597
> Project: HBase
> Issue Type: Bug
> Components: replication
> Affects Versions: 0.90.1
> Reporter: Otis Gospodnetic
> Assignee: Jean-Daniel Cryans
> Fix For: 0.90.3
>
> Attachments: HBASE-3597.patch
>
>
> The value of ageOfLastAppliedOp in JMX doesn't update after replication starts failing, and it should. See: http://search-hadoop.com/m/jFPgF1HfnLc
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3597) ageOfLastAppliedOp should update
after cluster replication failures
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028445#comment-13028445 ]
stack commented on HBASE-3597:
------------------------------
Looks fine. Aren't all those System.currentTimeMillis() expensive?
> ageOfLastAppliedOp should update after cluster replication failures
> -------------------------------------------------------------------
>
> Key: HBASE-3597
> URL: https://issues.apache.org/jira/browse/HBASE-3597
> Project: HBase
> Issue Type: Bug
> Components: replication
> Affects Versions: 0.90.1
> Reporter: Otis Gospodnetic
> Assignee: Jean-Daniel Cryans
> Fix For: 0.90.3
>
> Attachments: HBASE-3597.patch
>
>
> The value of ageOfLastAppliedOp in JMX doesn't update after replication starts failing, and it should. See: http://search-hadoop.com/m/jFPgF1HfnLc
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira