[GitHub] moltzaum commented on a change in pull request #3163: Fix Traffic Ops Tenancy and Activity Bugs, Fix TO API Test Framework to work with Tenancy

[GitBox <gi...@apache.org>]

moltzaum commented on a change in pull request #3163: Fix Traffic Ops Tenancy and Activity Bugs, Fix TO API Test Framework to work with Tenancy
URL: https://github.com/apache/trafficcontrol/pull/3163#discussion_r244183221
 
 

 ##########
 File path: traffic_ops/testing/api/v14/user_test.go
 ##########
 @@ -61,11 +63,10 @@ func CreateTestUsers(t *testing.T) {
 	for _, user := range testData.Users {
 
 		resp, _, err := TOSession.CreateUser(&user)
-		log.Debugln("Response: ", resp.Alerts)
-
 		if err != nil {
-			t.Errorf("could not CREATE user: %v\n", err)
+			t.Fatalf("could not CREATE user: %v\n", err)
 
 Review comment:
   @rob05c Nearly two months ago @dangogh changed Fatalf to Errorf across all tests because Fatalf tests from cleaning up (2928/commits/f32c5ec73db68ef9b24caa7ad6a0fb175051eaf0). It seems that other tests would have the same panic issue if their create method failed. I want to make sure we have a consistent understanding of how tests should terminate and why.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services