You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mahout.apache.org by ad...@apache.org on 2009/10/18 07:21:45 UTC
svn commit: r826354 - in /lucene/mahout/trunk/core/src:
main/java/org/apache/mahout/df/mapred/partial/PartialBuilder.java
test/java/org/apache/mahout/df/data/DataTest.java
test/java/org/apache/mahout/df/mapred/partial/PartialSequentialBuilder.java
Author: adeneche
Date: Sun Oct 18 05:21:45 2009
New Revision: 826354
URL: http://svn.apache.org/viewvc?rev=826354&view=rev
Log:
Changes related to the latest code tweaks
Modified:
lucene/mahout/trunk/core/src/main/java/org/apache/mahout/df/mapred/partial/PartialBuilder.java
lucene/mahout/trunk/core/src/test/java/org/apache/mahout/df/data/DataTest.java
lucene/mahout/trunk/core/src/test/java/org/apache/mahout/df/mapred/partial/PartialSequentialBuilder.java
Modified: lucene/mahout/trunk/core/src/main/java/org/apache/mahout/df/mapred/partial/PartialBuilder.java
URL: http://svn.apache.org/viewvc/lucene/mahout/trunk/core/src/main/java/org/apache/mahout/df/mapred/partial/PartialBuilder.java?rev=826354&r1=826353&r2=826354&view=diff
==============================================================================
--- lucene/mahout/trunk/core/src/main/java/org/apache/mahout/df/mapred/partial/PartialBuilder.java (original)
+++ lucene/mahout/trunk/core/src/main/java/org/apache/mahout/df/mapred/partial/PartialBuilder.java Sun Oct 18 05:21:45 2009
@@ -149,9 +149,6 @@
protected static void processOutput(JobConf job, Path outputPath,
int[] firstIds, TreeID[] keys, Node[] trees, PredictionCallback callback)
throws IOException {
- // TODO doesn't this assert throw NPE? looks like args are nullable
- assert keys.length == trees.length : "keys.length != trees.length";
-
FileSystem fs = outputPath.getFileSystem(job);
Path[] outfiles = DFUtils.listOutputFiles(fs, outputPath);
Modified: lucene/mahout/trunk/core/src/test/java/org/apache/mahout/df/data/DataTest.java
URL: http://svn.apache.org/viewvc/lucene/mahout/trunk/core/src/test/java/org/apache/mahout/df/data/DataTest.java?rev=826354&r1=826353&r2=826354&view=diff
==============================================================================
--- lucene/mahout/trunk/core/src/test/java/org/apache/mahout/df/data/DataTest.java (original)
+++ lucene/mahout/trunk/core/src/test/java/org/apache/mahout/df/data/DataTest.java Sun Oct 18 05:21:45 2009
@@ -278,8 +278,6 @@
sData = Utils.double2String(source);
dataset = DataLoader.generateDataset(descriptor, sData);
data = DataLoader.loadData(dataset, sData);
- // TODO code1 is not used?
- code1 = dataset.labelCode(Double.toString(label1));
int code2 = dataset.labelCode(Double.toString(label2));
// label2 should be the majority label
Modified: lucene/mahout/trunk/core/src/test/java/org/apache/mahout/df/mapred/partial/PartialSequentialBuilder.java
URL: http://svn.apache.org/viewvc/lucene/mahout/trunk/core/src/test/java/org/apache/mahout/df/mapred/partial/PartialSequentialBuilder.java?rev=826354&r1=826353&r2=826354&view=diff
==============================================================================
--- lucene/mahout/trunk/core/src/test/java/org/apache/mahout/df/mapred/partial/PartialSequentialBuilder.java (original)
+++ lucene/mahout/trunk/core/src/test/java/org/apache/mahout/df/mapred/partial/PartialSequentialBuilder.java Sun Oct 18 05:21:45 2009
@@ -147,8 +147,6 @@
@Override
protected DecisionForest parseOutput(JobConf job, PredictionCallback callback)
throws IOException {
- //int numMaps = job.getNumMapTasks();
-
DecisionForest forest = processOutput(firstOutput.keys, firstOutput.values, callback);
if (isStep2(job)) {