You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gearpump.apache.org by manuzhang <gi...@git.apache.org> on 2016/06/29 06:55:45 UTC

[GitHub] incubator-gearpump pull request #53: fix GEARPUMP-169, upgrade sbt-assembly ...

GitHub user manuzhang opened a pull request:

    https://github.com/apache/incubator-gearpump/pull/53

    fix GEARPUMP-169, upgrade sbt-assembly and shade

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/manuzhang/incubator-gearpump assemb

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-gearpump/pull/53.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #53
    
----
commit f8a866a87b8a739d728ec3684e6cc8ec73679688
Author: huafengw <fv...@gmail.com>
Date:   2016-06-28T11:36:32Z

    fix GEARPUMP-169, upgrade sbt-assembly and shade

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-gearpump issue #53: fix GEARPUMP-169, upgrade sbt-assembly and sha...

Posted by kkasravi <gi...@git.apache.org>.
Github user kkasravi commented on the issue:

    https://github.com/apache/incubator-gearpump/pull/53
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-gearpump issue #53: fix GEARPUMP-169, upgrade sbt-assembly and sha...

Posted by huafengw <gi...@git.apache.org>.
Github user huafengw commented on the issue:

    https://github.com/apache/incubator-gearpump/pull/53
  
    travis build fail


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-gearpump issue #53: fix GEARPUMP-169, upgrade sbt-assembly and sha...

Posted by manuzhang <gi...@git.apache.org>.
Github user manuzhang commented on the issue:

    https://github.com/apache/incubator-gearpump/pull/53
  
    I also removed cloudera dependencies


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-gearpump pull request #53: fix GEARPUMP-169, upgrade sbt-assembly ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-gearpump/pull/53


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-gearpump issue #53: fix GEARPUMP-169, upgrade sbt-assembly and sha...

Posted by manuzhang <gi...@git.apache.org>.
Github user manuzhang commented on the issue:

    https://github.com/apache/incubator-gearpump/pull/53
  
    the test failure is not related
    
    ```
    [info] Worker
    [info] - should register worker address to master when started. *** FAILED ***
    [info]   java.lang.AssertionError: assertion failed: timeout (25 seconds) during expectMsg while waiting for RegisterNewWorker
    [info]   at scala.Predef$.assert(Predef.scala:170)
    [info]   at akka.testkit.TestKitBase$class.expectMsg_internal(TestKit.scala:349)
    [info]   at akka.testkit.TestKitBase$class.expectMsg(TestKit.scala:335)
    [info]   at akka.testkit.TestKit.expectMsg(TestKit.scala:734)
    [info]   at org.apache.gearpump.cluster.main.MainSpec$$anonfun$1.apply$mcV$sp(MainSpec.scala:73)
    [info]   at org.apache.gearpump.cluster.main.MainSpec$$anonfun$1.apply(MainSpec.scala:56)
    [info]   at org.apache.gearpump.cluster.main.MainSpec$$anonfun$1.apply(MainSpec.scala:56)
    [info]   at org.scalatest.Transformer$$anonfun$apply$1.apply$mcV$sp(Transformer.scala:22)
    [info]   at org.scalatest.OutcomeOf$class.outcomeOf(OutcomeOf.scala:85)
    [info]   at org.scalatest.OutcomeOf$.outcomeOf(OutcomeOf.scala:104)
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-gearpump pull request #53: fix GEARPUMP-169, upgrade sbt-assembly ...

Posted by huafengw <gi...@git.apache.org>.
Github user huafengw commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/53#discussion_r68906960
  
    --- Diff: project/Build.scala ---
    @@ -104,6 +99,7 @@ object Build extends sbt.Build {
             System.getenv().get("SONATYPE_PASSWORD")),
     
           pomIncludeRepository := { _ => false },
    +      test in assembly := {},
    --- End diff --
    
    I think we can move this line to the myAssemblySettings?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---