[GitHub] [pinot] walterddr commented on a diff in pull request #10706: Add request id to the V2 broker response

["walterddr (via GitHub)" <gi...@apache.org>]

walterddr commented on code in PR #10706:
URL: https://github.com/apache/pinot/pull/10706#discussion_r1182651682


##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java:
##########
@@ -223,6 +223,7 @@ private BrokerResponse handleRequest(long requestId, String query, @Nullable Sql
         sqlNodeAndOptions.getParseTimeNs() + (executionEndTimeNs - compilationStartTimeNs));
     brokerResponse.setTimeUsedMs(totalTimeMs);
     brokerResponse.setResultTable(queryResults);
+    brokerResponse.setRequestId(requestId);

Review Comment:
   i was wondering if we should also set brokerId? b/c potentially 2 broker can generate the same requestID individually. but that's sort of a separate issue. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org