[GitHub] [arrow-datafusion] viirya commented on a diff in pull request #7658: Minor: add doc comments to `ExtractEquijoinPredicate`

["viirya (via GitHub)" <gi...@apache.org>]

viirya commented on code in PR #7658:
URL: https://github.com/apache/arrow-datafusion/pull/7658#discussion_r1337815826


##########
datafusion/optimizer/src/extract_equijoin_predicate.rs:
##########
@@ -28,7 +28,17 @@ use std::sync::Arc;
 // equijoin predicate
 type EquijoinPredicate = (Expr, Expr);
 
-/// Optimization rule that extract equijoin expr from the filter
+/// Optimizer that splits conjunctive join predicates into equijoin
+/// predicates and filter (other) predicates.

Review Comment:
   Small suggestion. It reads more smooth to me:
   
   ```suggestion
   /// Optimizer that splits conjunctive join predicates into equijoin
   /// predicates and (other) filter predicates.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org