You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/22 16:08:15 UTC
[GitHub] [arrow] lidavidm commented on a diff in pull request #12937: ARROW-16238: [C++] Fix nullptr dereference when pre-buffering IPC reads
lidavidm commented on code in PR #12937:
URL: https://github.com/apache/arrow/pull/12937#discussion_r856378066
##########
cpp/src/arrow/ipc/read_write_test.cc:
##########
@@ -1456,8 +1477,13 @@ class ReaderWriterMixin : public ExtensionTypesMixin {
class TestFileFormat : public ReaderWriterMixin<FileWriterHelper>,
public ::testing::TestWithParam<MakeRecordBatch*> {};
-class TestFileFormatGenerator : public ReaderWriterMixin<FileGeneratorWriterHelper>,
- public ::testing::TestWithParam<MakeRecordBatch*> {};
+class TestFileFormatGenerator
+ : public ReaderWriterMixin<FileGeneratorWriterHelper</*kCoalesce=*/false>>,
+ public ::testing::TestWithParam<MakeRecordBatch*> {};
+
+class TestFileFormatCoalesced
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org